-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): don't collect coverage for eol tests #4030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 321 321
Lines 9189 9189
Branches 1953 1953
=======================================
Hits 8483 8483
Misses 706 706 |
7 tasks
/easycla |
5 tasks
Fixes #4029 |
legendecas
approved these changes
Jul 31, 2023
aabmass
approved these changes
Jul 31, 2023
/easycla |
This was referenced Nov 27, 2023
[Snyk] Security upgrade @opentelemetry/sdk-node from 0.40.0 to 0.41.2
sumodgeorge/opentelemetry-js#7
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
nyc
requiresistanbul-lib-report
, which silently dropped support for Node.js v8 when going from3.0.0
to3.0.1
by requiring make-dir@^4.0.0 to fix GHSA-c2qf-rxjj-qqgw.make-dir@4.0.0
does not support Node.js v8 anymore, which causes the eol tests to fail.As we don't report the coverage in these tests, I opted to run the tests without
nyc
instead of pinning the package (as pinning would mean we're stuck with that version, which may prevent us from updating in the future, even though we don't use it).Short description of the changes
test:eol
script which runs tests, but does not run them withnyc
Type of change
How Has This Been Tested?