Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as dependency #3968

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jul 6, 2023

Which problem is this PR solving?

The docs workflow is failing as the dependency to @opentelemetry/api is missing (edit: fixed in the meantime by #4020). This PR adds @opentelemetry/api as a peer and dev dependency. @opentelemetry/api-logs was listed as a peer dependency. As @opentelemetry/api-logs is still experimental, this PR moves it to dependencies.

@opentelemetry/api being missing is likely not a problem when using the exporter, as it is included in other dependencies. However, it should be listed as a peer dependency regardless.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit tests
  • Running docs script locally

@pichlermarc pichlermarc marked this pull request as ready for review July 6, 2023 12:54
@pichlermarc pichlermarc requested a review from a team July 6, 2023 12:54
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3968 (26772c4) into main (432d439) will not change coverage.
The diff coverage is n/a.

❗ Current head 26772c4 differs from pull request most recent head 663118b. Consider uploading reports for the commit 663118b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3968   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         159      159           
  Lines        3757     3757           
  Branches      835      835           
=======================================
  Hits         3401     3401           
  Misses        356      356           

@pichlermarc pichlermarc changed the title fix(exporter-logs-otlp-http): add @opentelemetry/api as peer/dev dependency, add @opentelemetry/api-logs depenency fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as depenency Jul 31, 2023
@pichlermarc pichlermarc changed the title fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as depenency fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as dependency Jul 31, 2023
@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Aug 23, 2023
@pichlermarc pichlermarc merged commit c84637f into open-telemetry:main Aug 29, 2023
14 checks passed
@pichlermarc pichlermarc deleted the fix/http-logs-exporter-dependencies branch August 29, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants