fix(otlp-proto-exporter-base): add missing type import #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3937 +/- ##
==========================================
+ Coverage 92.90% 92.91% +0.01%
==========================================
Files 297 297
Lines 8838 8838
Branches 1815 1815
==========================================
+ Hits 8211 8212 +1
+ Misses 627 626 -1 |
pichlermarc
added
bug
Flarna
approved these changes
Jun 22, 2023
llc1123
reviewed
Jun 26, 2023
| @@ -16,6 +16,7 @@ All notable changes to experimental packages in this project will be documented | |||
| ### :bug: (Bug Fix) | |||
|
|
|||
| * fix(exporter-logs-otlp-http): set useHex to true [#3875](https://github.com/open-telemetry/opentelemetry-js/pull/3875) @Nico385412 | |||
| fix(otlp-proto-exporter-base): add missing type import [#3937](https://github.com/open-telemetry/opentelemetry-js/pull/3937) @pichlermarc | |||
There was a problem hiding this comment.
You are missing a * here.
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
See #3921, a type import is missing that causes compilation to fail when using any proto exporters.
Fixes #3921
Type of change
How Has This Been Tested?