Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minification): Add noEmitHelpers, importHelpers and tslib as a dependency #3914

Merged
merged 4 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(minification): Add noEmitHelpers, importHelpers and tslib as a d…
…ependency
  • Loading branch information
MSNev committed Jun 19, 2023
commit 3f64b2cd349cc446449187bd2669adeec15f8e12
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/

### :house: (Internal)

* feat(minification): [Minification] Add noEmitHelpers, importHelpers and tslib as a dependency [#3913](https://github.com/open-telemetry/opentelemetry-js/issues/3913)

## 1.14.0

### :rocket: (Enhancement)
Expand Down
3 changes: 3 additions & 0 deletions api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@
"unionfs": "4.5.1",
"webpack": "4.46.0"
},
"dependencies": {
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/api",
"sideEffects": false
}
4 changes: 3 additions & 1 deletion examples/esm-http-ts/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
"forceConsistentCasingInFileNames": true /* Ensure that casing is correct in imports. */,

/* Completeness */
"skipLibCheck": true /* Skip type checking all .d.ts files. */
"skipLibCheck": true /* Skip type checking all .d.ts files. */,
"importHelpers": true,
"noEmitHelpers": true
},
"include": ["**/*.ts", "**/*.js", "*.config.js"],
"exclude": ["node_modules"]
Expand Down
3 changes: 2 additions & 1 deletion examples/opentelemetry-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
"@opentelemetry/sdk-metrics": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0",
"@opentelemetry/sdk-trace-web": "1.14.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/examples/tracer-web"
}
3 changes: 2 additions & 1 deletion experimental/backwards-compatibility/node14/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
},
"dependencies": {
"@opentelemetry/sdk-node": "0.40.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"devDependencies": {
"@types/node": "14.18.25",
Expand Down
3 changes: 2 additions & 1 deletion experimental/backwards-compatibility/node16/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
},
"dependencies": {
"@opentelemetry/sdk-node": "0.40.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"devDependencies": {
"@types/node": "16.11.52",
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/api-events/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"access": "public"
},
"dependencies": {
"@opentelemetry/api": "^1.0.0"
"@opentelemetry/api": "^1.0.0",
"tslib": "^2.3.1"
},
"devDependencies": {
"@types/mocha": "10.0.1",
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/api-logs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"access": "public"
},
"dependencies": {
"@opentelemetry/api": "^1.0.0"
"@opentelemetry/api": "^1.0.0",
"tslib": "^2.3.1"
},
"devDependencies": {
"@types/mocha": "10.0.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
"@opentelemetry/core": "1.14.0",
"@opentelemetry/otlp-grpc-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/sdk-logs": "0.40.0"
"@opentelemetry/sdk-logs": "0.40.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-logs-otlp-grpc",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
"@opentelemetry/core": "1.14.0",
"@opentelemetry/otlp-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/sdk-logs": "0.40.0"
"@opentelemetry/sdk-logs": "0.40.0",
"tslib": "^2.3.1"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-logs": "0.40.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-logs-otlp-proto",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@
"@opentelemetry/otlp-grpc-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-trace-otlp-grpc",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"@opentelemetry/otlp-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-trace-otlp-http",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@
"@opentelemetry/otlp-proto-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-trace-otlp-proto",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
},
"dependencies": {
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/browser-detector"
}
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@
"@opentelemetry/otlp-grpc-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-metrics": "1.14.0"
"@opentelemetry/sdk-metrics": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"@opentelemetry/otlp-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-metrics": "1.14.0"
"@opentelemetry/sdk-metrics": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-metrics-otlp-http",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"@opentelemetry/otlp-proto-exporter-base": "0.40.0",
"@opentelemetry/otlp-transformer": "0.40.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-metrics": "1.14.0"
"@opentelemetry/sdk-metrics": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-metrics-otlp-proto",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
"dependencies": {
"@opentelemetry/core": "1.14.0",
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-metrics": "1.14.0"
"@opentelemetry/sdk-metrics": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-prometheus",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@
"@opentelemetry/core": "1.14.0",
"@opentelemetry/instrumentation": "0.40.0",
"@opentelemetry/sdk-trace-web": "1.14.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-fetch",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
},
"dependencies": {
"@opentelemetry/instrumentation": "0.40.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-grpc",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
"@opentelemetry/core": "1.14.0",
"@opentelemetry/instrumentation": "0.40.0",
"@opentelemetry/semantic-conventions": "1.14.0",
"semver": "^7.5.1"
"semver": "^7.5.1",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-http",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@
"@opentelemetry/core": "1.14.0",
"@opentelemetry/instrumentation": "0.40.0",
"@opentelemetry/sdk-trace-web": "1.14.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-xml-http-request",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"import-in-the-middle": "1.3.5",
"require-in-the-middle": "^7.1.1",
"semver": "^7.5.1",
"shimmer": "^1.2.1"
"shimmer": "^1.2.1",
"tslib": "^2.3.1"
},
"peerDependencies": {
"@opentelemetry/api": "^1.3.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
* limitations under the License.
*/

export * from './instrumentation';
export { InstrumentationBase } from './instrumentation';
MSNev marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@
* limitations under the License.
*/

export * from './node';
export {
InstrumentationBase,
InstrumentationModuleDefinition,
InstrumentationModuleFile,
InstrumentationNodeModuleDefinition,
InstrumentationNodeModuleFile
} from './node';
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export * from './instrumentation';
export * from './instrumentationNodeModuleDefinition';
export * from './instrumentationNodeModuleFile';
export * from './types';
export { InstrumentationBase } from './instrumentation';
export { InstrumentationNodeModuleDefinition } from './instrumentationNodeModuleDefinition';
export { InstrumentationNodeModuleFile } from './instrumentationNodeModuleFile';
export { InstrumentationModuleDefinition, InstrumentationModuleFile } from './types';
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import * as assert from 'assert';
import {
InstrumentationBase,
InstrumentationNodeModuleDefinition,
} from '../../build/src/index.js';
} from '../../build/src/platform/index.js';
MSNev marked this conversation as resolved.
Show resolved Hide resolved
import * as exported from 'test-esm-module';

class TestInstrumentationWrapFn extends InstrumentationBase {
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/opentelemetry-sdk-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"@opentelemetry/sdk-metrics": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0",
"@opentelemetry/sdk-trace-node": "1.14.0",
"@opentelemetry/semantic-conventions": "1.14.0"
"@opentelemetry/semantic-conventions": "1.14.0",
"tslib": "^2.3.1"
},
"peerDependencies": {
"@opentelemetry/api": ">=1.3.0 <1.5.0"
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/otlp-exporter-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"access": "public"
},
"dependencies": {
"@opentelemetry/core": "1.14.0"
"@opentelemetry/core": "1.14.0",
"tslib": "^2.3.1"
},
"devDependencies": {
"@opentelemetry/api": "1.4.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"@grpc/grpc-js": "^1.7.1",
"@opentelemetry/core": "1.14.0",
"@opentelemetry/otlp-exporter-base": "0.40.0",
"protobufjs": "^7.2.3"
"protobufjs": "^7.2.3",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/otlp-grpc-exporter-base",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
"dependencies": {
"@opentelemetry/core": "1.14.0",
"@opentelemetry/otlp-exporter-base": "0.40.0",
"protobufjs": "^7.2.3"
"protobufjs": "^7.2.3",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/otlp-proto-exporter-base",
"sideEffects": false
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/otlp-transformer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@
"@opentelemetry/resources": "1.14.0",
"@opentelemetry/sdk-logs": "0.40.0",
"@opentelemetry/sdk-metrics": "1.14.0",
"@opentelemetry/sdk-trace-base": "1.14.0"
"@opentelemetry/sdk-trace-base": "1.14.0",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/otlp-transformer",
"sideEffects": false
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/sdk-logs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
},
"dependencies": {
"@opentelemetry/core": "1.14.0",
"@opentelemetry/resources": "1.14.0"
"@opentelemetry/resources": "1.14.0",
"tslib": "^2.3.1"
}
}
3 changes: 2 additions & 1 deletion experimental/packages/shim-opencensus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
"dependencies": {
"@opentelemetry/core": "1.14.0",
"require-in-the-middle": "^7.1.1",
"semver": "^7.5.1"
"semver": "^7.5.1",
"tslib": "^2.3.1"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/shim-opencensus",
"sideEffects": false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"@opentelemetry/sdk-trace-base": "1.14.0",
"axios": "1.4.0",
"body-parser": "1.19.0",
"express": "4.17.3"
"express": "4.17.3",
"tslib": "^2.3.1"
},
"devDependencies": {
"typescript": "4.4.4"
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
"typedoc": "0.22.18",
"typedoc-plugin-missing-exports": "1.0.0",
"typedoc-plugin-resolve-crossmodule-references": "0.2.2",
"typescript": "4.4.4"
"typescript": "4.4.4",
"tslib": "^2.3.1"
},
"changelog": {
"repo": "open-telemetry/opentelemetry-js",
Expand Down
3 changes: 3 additions & 0 deletions packages/opentelemetry-context-async-hooks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
"publishConfig": {
"access": "public"
},
"dependencies": {
"tslib": "^2.3.1"
},
"devDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.5.0",
"@types/mocha": "10.0.1",
Expand Down
3 changes: 3 additions & 0 deletions packages/opentelemetry-context-zone-peer-dep/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@
"@opentelemetry/api": ">=1.0.0 <1.5.0",
"zone.js": "^0.10.2 || ^0.11.0"
},
"dependencies": {
"tslib": "^2.3.1"
},
"sideEffects": false,
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-context-zone-peer-dep"
}
3 changes: 2 additions & 1 deletion packages/opentelemetry-context-zone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
},
"dependencies": {
"@opentelemetry/context-zone-peer-dep": "1.14.0",
"zone.js": "^0.11.0"
"zone.js": "^0.11.0",
"tslib": "^2.3.1"
},
"sideEffects": true,
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-context-zone"
Expand Down
Loading