feat(metrics): prototype experimental advice support #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
added
api:metrics
legendecas
force-pushed
the
metrics/advice
branch
3 times, most recently
from
181232e
to
8b2188e
Compare
Codecov Report
@@ Coverage Diff @@
## main #3876 +/- ##
==========================================
+ Coverage 92.24% 92.53% +0.28%
==========================================
Files 331 317 -14
Lines 9479 8907 -572
Branches 1999 1877 -122
==========================================
- Hits 8744 8242 -502
+ Misses 735 665 -70
|
legendecas
force-pushed
the
metrics/advice
branch
from
8b2188e
to
d47603f
Compare
5 tasks
|
open-telemetry/opentelemetry-specification#3391 (comment) The advice API needs one more language implementation to be advanced to stable status. @open-telemetry/javascript-approvers would you mind taking a look at this? Thank you! |
dyladan
approved these changes
Aug 11, 2023
| @@ -207,7 +211,7 @@ export class HistogramAggregator implements Aggregator<HistogramAccumulation> { | |||
| } | |||
|
|
|||
| toMetricData( | |||
| descriptor: InstrumentDescriptor, | |||
| descriptor: MetricDescriptor, | |||
There was a problem hiding this comment.
It is needed to avoid exposing the advice on the InstrumentDescriptor to the MetricReaders and the MetricExporters.
# Conflicts: # CHANGELOG.md # packages/sdk-metrics/src/ObservableResult.ts
pichlermarc
reviewed
Sep 13, 2023
6 tasks
# Conflicts: # CHANGELOG.md # api/CHANGELOG.md # packages/sdk-metrics/src/InstrumentDescriptor.ts
pichlermarc
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3722, #3619
Short description of the changes
MetricDescriptor) and internal interfaceInstrumentDescriptorso that the advice is not exposed to exporters.Type of change
How Has This Been Tested?
createHistogramwith advice and verify the exported boundaries.Checklist: