Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update http example #3651

Merged
merged 6 commits into from
Mar 2, 2023

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

The http example had outdated dependencies, and were still using older functions for getting active spans when newer convenience APIs are available now.

Short description of the changes

  • Updates dependencies in package.json
    • It seems like these are usually updated with each release now, but this was further behind than the others so it probably wasn't as obvious with a Find/Replace
  • Uses newer startActiveSpan() and getActiveSpan()

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual testing with new and old versions of packages to ensure the same results

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@JamieDanielson JamieDanielson requested a review from a team March 1, 2023 22:40
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #3651 (d950b6e) into main (494efff) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d950b6e differs from pull request most recent head e974782. Consider uploading reports for the commit e974782 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   93.73%   93.72%   -0.02%     
==========================================
  Files         274      274              
  Lines        8060     8060              
  Branches     1671     1671              
==========================================
- Hits         7555     7554       -1     
- Misses        505      506       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for updating this 🙂

If you'd like you could also add the example to lerna.json as we did with the other already updated examples. This way the OTel dependencies will keep up-to-date as we release new versions. 🙂

@JamieDanielson
Copy link
Member Author

If you'd like you could also add the example to lerna.json as we did with the other already updated examples. This way the OTel dependencies will keep up-to-date as we release new versions. 🙂

Ah, I didn't see that! Makes sense. Looks like @dyladan took care of that for me this time but good to know.

@dyladan dyladan merged commit 4a4484a into open-telemetry:main Mar 2, 2023
@JamieDanielson JamieDanielson deleted the update-examples branch March 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants