fix(instrumentation-http): include query params in http.target #3646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
According to the spec,
http.target
attribute should include path + query params, current implementation sets the path without query params.Short description of the changes
Fix
http.target
to use urlObject.path and not urlObject.pathname which is the value the includes the query params.Type of change
Bug fix
How Has This Been Tested?
Created a new unit test to check http.target attribute value.