Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-metrics): fix duplicated registration of metrics for collectors #3488

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
* `telemetry.sdk.language`
* `telemetry.sdk.version`
* fix(selenium-tests): updated webpack version for selenium test issue [#3456](https://github.com/open-telemetry/opentelemetry-js/issues/3456) @SaumyaBhushan
* fix(sdk-metrics): fix duplicated registration of metrics for collectors [#3488](https://github.com/open-telemetry/opentelemetry-js/pull/3488) @legendecas

### :books: (Refine Doc)

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk-metrics/src/state/MetricStorageRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class MetricStorageRegistry {
return null;
}

const storages = this._sharedRegistry.get(expectedDescriptor.name);
const storages = storageMap.get(expectedDescriptor.name);
if (storages === undefined) {
return null;
}
Expand Down
15 changes: 15 additions & 0 deletions packages/sdk-metrics/test/state/MetricStorageRegistry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,22 @@ describe('MetricStorageRegistry', () => {

// registered the storage for each collector
assert.deepStrictEqual(registry.getStorages(collectorHandle), [storage]);
assert.strictEqual(
registry.findOrUpdateCompatibleCollectorStorage(
collectorHandle,
descriptor
),
storage
);

assert.deepStrictEqual(registry.getStorages(collectorHandle2), [storage]);
assert.strictEqual(
registry.findOrUpdateCompatibleCollectorStorage(
collectorHandle2,
descriptor
),
storage
);
});
});
});