fix: enforce consistent span durations

.github/workflows/docs.yaml

@@ -16,7 +16,7 @@ jobs:
           node-version: '14'
 
       - name: restore lock files
-        uses: actions/cache@master # must use unreleased master to cache multiple paths
+        uses: actions/cache@v3
         id: cache
         with:
           # must be done before bootstrap to not include node_modules files in the cache paths

.github/workflows/unit-test.yml

@@ -108,7 +108,7 @@ jobs:
 
       - name: restore lerna
         id: cache
-        uses: actions/cache@v3
+        uses: actions/cache@v3.0.4 # Pin version for now to prevent permissions issues
         with:
           path: |
             node_modules
@@ -148,7 +148,7 @@ jobs:
 
       - name: restore lerna
         id: cache
-        uses: actions/cache@v3
+        uses: actions/cache@v3.0.4 # Pin version for now to prevent permissions issues
         with:
           path: |
             node_modules

.github/workflows/w3c-integration-test.yml

@@ -18,7 +18,7 @@ jobs:
           node-version: '16'
 
       - name: restore lock files
-        uses: actions/cache@master # must use unreleased master to cache multiple paths
+        uses: actions/cache@v3
         id: cache
         with:
           # must be done before bootstrap to not include node_modules files in the cache paths

CHANGELOG.md

@@ -12,6 +12,8 @@ All notable changes to this project will be documented in this file.
 
 ### :bug: (Bug Fix)
 
+* fix(sdk-trace): enforce consistent span durations [#3327](https://github.com/open-telemetry/opentelemetry-js/pull/3327) @dyladan
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

packages/opentelemetry-sdk-trace-base/src/Span.ts

@@ -15,7 +15,7 @@
  */
 
 import * as api from '@opentelemetry/api';
-import { Context, SpanAttributeValue } from '@opentelemetry/api';
+import { Context, HrTime, SpanAttributeValue } from '@opentelemetry/api';
 import {
   Clock,
   hrTimeDuration,
@@ -191,10 +191,12 @@ export class Span implements api.Span, ReadableSpan {
 
     if (this._duration[0] < 0) {
       api.diag.warn(
-        'Inconsistent start and end time, startTime > endTime',
+        'Inconsistent start and end time, startTime > endTime. Setting end time 1ms after start time.',
         this.startTime,
         this.endTime
       );
+      this.endTime = this.startTime.slice() as HrTime;
+      this._duration = [0, 0];
     }
 
     this._spanProcessor.onEnd(this);

packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts

@@ -128,6 +128,18 @@ describe('Span', () => {
     assert.ok(hrTimeToNanoseconds(span.duration) >= 0);
   });
 
+  it('should ensure duration is never negative even if provided with inconsistent times', () => {
+    const span = new Span(
+      tracer,
+      ROOT_CONTEXT,
+      name,
+      spanContext,
+      SpanKind.SERVER
+    );
+    span.end(hrTimeToMilliseconds(span.startTime) - 1);
+    assert.ok(hrTimeToNanoseconds(span.duration) >= 0);
+  });
+
   it('should have valid event.time', () => {
     const span = new Span(
       tracer,