-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resources): fix when attribute values contain spaces #3302
fix(resources): fix when attribute values contain spaces #3302
Conversation
@anthony-telljohann You'll need to sign the CLA with above comment so we can accept the contribution |
I'll work with my company on getting the CLA signed first thing Monday morning. |
Any update on the CLA? |
packages/opentelemetry-resources/test/detectors/node/EnvDetector.test.ts
Outdated
Show resolved
Hide resolved
Still working on it. We have a list of people that meet the requirements to be CLA Managers. Still need to find one that is able and willing to create the CLA Manager account to authorize the contribution. |
Just noticed some of the eslint errors. I'll patch this up asap. |
Still working on getting the CLA signed. |
Browser and webworker failures are unrelated. See #3328 |
So close to getting the CLA signed. I've got the correct person to make the EasyCLA account. |
CLA signed. |
@dyladan would love to merge this in as soon as possible. Anything I can do to help expedite? |
Nope. I merged main into this earlier and was just waiting for tests to pass. |
Which problem is this PR solving?
EnvDetector throwing errors when attribute values contain spaces.
Fixes #3295
Short description of the changes
EnvDetector no longer throws errors when an attribute value contains a space.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: