Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): add new setMeterInstruments method #3267

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2fafb4c
feat(instrumentation): add new protected method that update the mete…
osherv Sep 19, 2022
5188bb9
feat(instrumentation): fixed markdown lint
osherv Sep 19, 2022
b92bb79
Update experimental/packages/opentelemetry-instrumentation/src/instru…
osherv Sep 20, 2022
a1d9119
Update experimental/packages/opentelemetry-instrumentation/src/instru…
osherv Sep 20, 2022
d5b3ddc
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Sep 20, 2022
77c9374
feat(instrumentation): renamed function
osherv Sep 20, 2022
75af723
feat(instrumentation): adapted http instrumentation to the new api
osherv Sep 20, 2022
210b77b
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 6, 2022
f768af1
feat(instrumentation): added tests
osherv Nov 6, 2022
d6952f8
Merge branch 'feat/add-update-metric-instruments-interface' of github…
osherv Nov 6, 2022
7328f00
feat(instrumentation): resolved conlicts
osherv Nov 6, 2022
c6c2be9
feat(instrumentation): fixed legendcas CR
osherv Nov 7, 2022
f65c81e
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 8, 2022
244cd98
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 9, 2022
8f70a7f
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 10, 2022
fe7880c
feat(instrumentation): fixed dyladan's CR
osherv Nov 10, 2022
9df8e43
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 13, 2022
3bfca7f
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 14, 2022
0ef2766
feat(instrumentation): fixed vmarchaud's CR
osherv Nov 14, 2022
ca02353
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 15, 2022
f31f953
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 16, 2022
2e550f8
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 17, 2022
7c67a60
Merge branch 'main' into feat/add-update-metric-instruments-interface
osherv Nov 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to experimental packages in this project will be documented

## Unreleased

* feat(instrumentation): add new `_setMeterInstruments` protected method that update the meter instruments every
legendecas marked this conversation as resolved.
Show resolved Hide resolved
meter provider update.

*

### :boom: Breaking Change

### :rocket: (Enhancement)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ implements types.Instrumentation {
this._tracer = trace.getTracer(instrumentationName, instrumentationVersion);

this._meter = metrics.getMeter(instrumentationName, instrumentationVersion);
this._setMeterInstruments();
}

/* Api to wrap instrumented method */
Expand All @@ -79,6 +80,15 @@ implements types.Instrumentation {
this.instrumentationName,
this.instrumentationVersion
);

this._setMeterInstruments();
}

/**
* Sets the new meter instruments with the current Meter Provider.
osherv marked this conversation as resolved.
Show resolved Hide resolved
*/
protected _setMeterInstruments(): void {
osherv marked this conversation as resolved.
Show resolved Hide resolved
return;
}

/* Returns InstrumentationConfig */
Expand Down