Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: browser support for exporter-trace-otlp-proto #3208
feat: browser support for exporter-trace-otlp-proto #3208
Changes from 36 commits
915ce52
87327f0
b7c8c19
1fec3b3
4214129
d33f9bb
3dd4e17
35c193f
5ed212d
933d37e
9953561
5e87c85
1616d2b
e3043b0
0020c98
6125ec2
c420fd0
f260db8
fb6cfd2
3d9ae04
46b665a
2000c41
6366e4b
50e1af0
302e09c
a16fcf5
266d293
4cd39c0
ed1835e
84be752
d92f5fe
61c7be7
3eed4bb
c618265
cbabbf1
519fa7c
5f67e56
ad2aa0e
e57f0f2
b26fd7f
f421989
8064d5b
2678ff3
c898ea2
d48503a
a800550
598bc56
5596d13
1788269
2e0c4ec
9429864
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion
This is a little more readable, performant (and minifiable) by rewriting as
As well as less error prone for someone coming looking at this after you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSNev The function
getDefaultUrl
is written this way in multiple packages. I suggest we take this up in a separate PR since it's unrelated to this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we raise an issue for this then, otherwise it will not get done. This can include the suggestion I have above as the implementation.