Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(otlp-grpc-exporter): update default url #2726

Merged
merged 12 commits into from
Feb 8, 2022
Merged

docs(otlp-grpc-exporter): update default url #2726

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
946f005
docs(otlp-grpc-exporter): update default url
svetlanabrennan Jan 20, 2022
5243e03
Merge branch 'main' into fix-oltp-grpc-exporter-readme
svetlanabrennan Jan 20, 2022
bd76a70
docs(otlp-grpc-exporter): update recommended url scheme
svetlanabrennan Jan 25, 2022
7ed2760
Merge branch 'fix-oltp-grpc-exporter-readme' of github.com:svetlanabr…
svetlanabrennan Jan 25, 2022
83377d3
Merge branch 'fix-oltp-grpc-exporter-readme' of github.com:svetlanabr…
svetlanabrennan Jan 25, 2022
10b0f6d
Merge branch 'main' into fix-oltp-grpc-exporter-readme
svetlanabrennan Jan 27, 2022
16dc23f
Merge branch 'main' into fix-oltp-grpc-exporter-readme
svetlanabrennan Jan 31, 2022
a5fde50
Merge branch 'main' into fix-oltp-grpc-exporter-readme
svetlanabrennan Jan 31, 2022
8efc0c8
docs(otlp-grpc-exporter): remove mention of default schemeless url
svetlanabrennan Jan 31, 2022
56e89f1
Merge branch 'fix-oltp-grpc-exporter-readme' of github.com:svetlanabr…
svetlanabrennan Jan 31, 2022
5089cc0
Merge branch 'main' into fix-oltp-grpc-exporter-readme
vmarchaud Feb 6, 2022
6f223f5
Merge branch 'main' into fix-oltp-grpc-exporter-readme
legendecas Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/exporter-trace-otlp-grpc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/sdk
const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc');

const collectorOptions = {
// url is optional and can be omitted - default is grpc://localhost:4317
url: 'grpc://<collector-hostname>:<port>',
// url is optional and can be omitted - default is localhost:4317
url: '<collector-hostname>:<port>',
};

const provider = new BasicTracerProvider();
Expand All @@ -50,8 +50,8 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/sdk
const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc');

const collectorOptions = {
// url is optional and can be omitted - default is grpc://localhost:4317
url: 'grpc://<collector-hostname>:<port>',
// url is optional and can be omitted - default is localhost:4317
url: '<collector-hostname>:<port>',
credentials: grpc.credentials.createSsl(),
};

Expand Down Expand Up @@ -90,8 +90,8 @@ const metadata = new grpc.Metadata();
metadata.set('k', 'v');

const collectorOptions = {
// url is optional and can be omitted - default is grpc://localhost:4317
url: 'grpc://<collector-hostname>:<port>',
// url is optional and can be omitted - default is localhost:4317
url: '<collector-hostname>:<port>',
metadata, // // an optional grpc.Metadata object to be sent with each request
};

Expand Down