Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric-reader): add metric-reader #2681

Merged
merged 22 commits into from
Jan 7, 2022
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6c4f989
feat(metric-reader): add metric-reader.
pichlermarc Dec 20, 2021
4a767a7
refactor(metric-reader): use callbacks
pichlermarc Dec 21, 2021
fd04ff4
refactor(metric-reader): add options so that timeout can be omitted.
pichlermarc Dec 22, 2021
df2af4a
refactor(metric-reader): combine TestMetricExporter with WaitingMetri…
pichlermarc Dec 22, 2021
8390e4a
fix(metric-reader): update shutdown and forceFlush usages, fix style.
pichlermarc Dec 22, 2021
78d582d
refactor(metric-reader): add default implementation for onInitialized…
pichlermarc Dec 23, 2021
381c8a0
refactor(metric-reader): use promise pattern instead of callbacks
pichlermarc Jan 4, 2022
f9ec116
refactor(metric-reader): update metric collector to use the promise p…
pichlermarc Jan 4, 2022
fcfe6b7
fix(metric-reader): pass function instead of Promise to assert.reject…
pichlermarc Jan 4, 2022
6d2690b
fix(metric-reader): do not collect and export before force-flushing t…
pichlermarc Jan 4, 2022
2346295
refactor(metric-reader): remove unused ReaderResult
pichlermarc Jan 5, 2022
59697cf
fix(metric-reader): do not throw on multiple shutdown calls.
pichlermarc Jan 5, 2022
5fa2f39
refactor(metric-reader): move callWithTimeout and TimeoutError to src…
pichlermarc Jan 5, 2022
5081c9c
docs(metric-reader): add link to describe why the prototype is set ma…
pichlermarc Jan 5, 2022
3158422
fix(metric-reader): fix switched-out reader and force-flush options.
pichlermarc Jan 5, 2022
282a75d
fix(metric-reader): do not use default timeouts.
pichlermarc Jan 5, 2022
9a4b24b
fix(metric-reader): make options argument optional, cleanup.
pichlermarc Jan 7, 2022
0ff2c92
fix(metric-reader): actually add batch to _batches in TestMetricExporter
pichlermarc Jan 7, 2022
471d5d5
fix(metric-reader): add test-case for timed-out export.
pichlermarc Jan 7, 2022
a3b6796
docs(metric-reader): add TODO comment for BindOncePromise.
pichlermarc Jan 7, 2022
2de4fc9
fix(metric-reader): do not throw on collect and forceFlush when insta…
pichlermarc Jan 7, 2022
056ea19
refactor(metric-reader): remove empty options from calls in MetricCol…
pichlermarc Jan 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(metric-reader): remove empty options from calls in MetricCol…
…lector.
  • Loading branch information
pichlermarc committed Jan 7, 2022
commit 056ea1991d7311abf3b992e072b57de72711078c
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ export class MetricCollector implements MetricProducer {
* Delegates for MetricReader.forceFlush.
*/
async forceFlush(): Promise<void> {
await this._metricReader.forceFlush({});
await this._metricReader.forceFlush();
}

/**
* Delegates for MetricReader.shutdown.
*/
async shutdown(): Promise<void> {
await this._metricReader.shutdown({});
await this._metricReader.shutdown();
}
}

Expand Down