Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename metrics packages to prevent lerna linking #2629

Merged
merged 4 commits into from
Nov 20, 2021
Merged

chore: rename metrics packages to prevent lerna linking #2629

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8db5338
chore: use 0.1.0 for metrics packages to prevent lerna linking
dyladan Nov 17, 2021
0bee833
chore: use wip name instead of version
dyladan Nov 17, 2021
d4bd691
chore: update ts references
dyladan Nov 19, 2021
3c5cb0c
chore: temporarily move api metrics to dependencies
dyladan Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: temporarily move api metrics to dependencies
  • Loading branch information
@dyladan
dyladan committed Nov 19, 2021
commit 3c5cb0ca790c7243898241fbb4094f66c72812f5
6 changes: 3 additions & 3 deletions experimental/packages/opentelemetry-sdk-metrics-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
},
"devDependencies": {
"@opentelemetry/api": "^1.0.3",
"@opentelemetry/api-metrics-wip": "0.27.0",
"@types/lodash.merge": "4.6.6",
"@types/mocha": "8.2.3",
"@types/node": "14.17.33",
Expand All @@ -62,10 +61,11 @@
"typescript": "4.4.4"
},
"peerDependencies": {
"@opentelemetry/api": "^1.0.3",
"@opentelemetry/api-metrics-wip": "0.27.0"
"@opentelemetry/api": "^1.0.3"
},
"todo": "Move API metrics to peer dependencies. While it is using an unpublished name, lerna doesn't properly link it if it is in peer dependencies",
"dependencies": {
"@opentelemetry/api-metrics-wip": "0.27.0",
"@opentelemetry/core": "1.0.1",
"@opentelemetry/resources": "1.0.1",
"lodash.merge": "4.6.2"
Expand Down