-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(context): Fix links, edit prose #2619
Merged
vmarchaud
merged 11 commits into
open-telemetry:main
from
spencerwilson:sw/context-docs
Jan 31, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e86bb17
fix pkgs-that-break-ah link
spencerwilson 7d9c732
doc(context): Fix links, edit prose
spencerwilson 2993bf8
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
spencerwilson 1ed9290
restore newline
spencerwilson 4f820cb
Merge branch 'main' into sw/context-docs
dyladan 85a4319
Update packages/opentelemetry-context-async-hooks/README.md
dyladan 34ece4b
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
spencerwilson ca416e3
docs(context-async-hooks): copy changes
spencerwilson 6e5ab03
docs(lint): maybe fix things
spencerwilson 8162621
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
spencerwilson 5e9368a
Merge branch 'main' into sw/context-docs
vmarchaud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsyncLocalStorage isn't available for Node < 14.6 so we should document this there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also available for node ^12.17 and node ^13.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the node 14 docs it was introduced in 13.10 so I think it is available in all v14 versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that
AsyncLocalStorage
was added as experimental in 13.10 and it is still marked as experimental on 12 and 14 release lines (ignoring 13 and 15 for now as they are EOL anyway).It was move out of experimental with 16.4.0.
There were several important fixes done in that area during the first 14.x releases resulting in using it only for >=14.8.0 in
NodeTracerProvider
.I think all these fixes were backported to the 12.x line but most likely not with 12.17.0.