-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WIP metrics SDK #2601
Conversation
eb4a81c
to
1c71ef6
Compare
Codecov Report
@@ Coverage Diff @@
## main #2601 +/- ##
==========================================
+ Coverage 92.87% 93.26% +0.38%
==========================================
Files 98 115 +17
Lines 3662 4645 +983
Branches 831 1036 +205
==========================================
+ Hits 3401 4332 +931
- Misses 261 313 +52
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for a new wip package so that we can move forward at a fast pace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this PR is not meant to be complete, so feel to address some of the comments in later PRs if that's easier
experimental/packages/opentelemetry-sdk-metrics-base-wip/README.md
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/package.json
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/Meter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/MeterProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/MeterProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/Metric.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/MetricExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base-wip/src/Metric.ts
Outdated
Show resolved
Hide resolved
1c71ef6
to
9ac4f10
Compare
experimental/packages/opentelemetry-sdk-metrics-base/src/Instruments.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/Instruments.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/MeterProvider.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/MeterProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/MeterProvider.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when #2601 (comment) is resolve
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very optional, but I think having the links to the respective spec pages is great. Just adding these here for completeness, we could however always add them later (or remove them if we don't want them).
experimental/packages/opentelemetry-sdk-metrics-base/src/MetricExporter.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/MetricReader.ts
Show resolved
Hide resolved
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
… into wip-metrics-sdk
This is the start of a ground-up rewrite of the metrics SDK. Even if we decide not to move forward with #2598 I think it makes sense to rethink the SDK from the beginning.