-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-metrics): add schemaUrl to meter creations #2529
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2529 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 140 140
Lines 5169 5169
Branches 1101 1101
=======================================
Hits 4811 4811
Misses 358 358
|
cb9de22
to
94b67f1
Compare
new Meter({ | ||
name, | ||
version: config?.version, | ||
// @ts-expect-error ts(2345) TODO: define the types in @opentelemetry/core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder how could we can handle this more cleanly ? i expect this will happen commonly on the feature when experimental requires change on stable packages :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it is possible to link packages/*
to the lerna project in experimental/
. Even if it is possible, I'd believe we need a solution to publish experimental packages apart from the stable ones, that would eventually require a separate lerna project? Maybe @dyladan can chime on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not possible to link them together with the current setup. We could go back to the way it was before where all packages are part of the same lerna repo but make scripts which call lerna commands only on specific packages and use the independent
version scheme? Having two groups of packages in lerna seems to be a thorny bit of business that there is no clear cut solution for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think going back is necessary now. I would prefer to investigate alternative to lerna that suit our use case to avoid putting effort inside it, WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to this
open-telemetry/opentelemetry-js-api#125
I think we should add 3rd param, without changing the 2nd one
experimental/packages/opentelemetry-api-metrics/src/NoopMeterProvider.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and agree version should be param and schemaUrl should be in an options object.
Is there already an issue to add schema url to the tracing API/SDK?
@aabmass it's been tracked here open-telemetry/opentelemetry-js-api#125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Short description of the changes
MeterProvider.getMeter
.schemaUrl
toInstrumentationLibrary
in@opentelemetry/core
. This is not a breaking change.