Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add esModuleInterop compatibility test #2506

Merged
merged 6 commits into from
Sep 30, 2021

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

  • Ensure published OTEL js SDK typings are compatible with tsc esModuleInterop flag.

Short description of the changes

  • Checks if opentelemetry js SDK are compatible when consumer enabled tsc esModuleInterop flag.

@legendecas legendecas requested a review from a team September 29, 2021 03:37
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #2506 (d9007f5) into main (9ac1d8e) will not change coverage.
The diff coverage is n/a.

❗ Current head d9007f5 differs from pull request most recent head 29e3234. Consider uploading reports for the commit 29e3234 to get more accurate results

@@           Coverage Diff           @@
##             main    #2506   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         137      137           
  Lines        5042     5042           
  Branches     1066     1066           
=======================================
  Hits         4701     4701           
  Misses        341      341           

@dyladan
Copy link
Member

dyladan commented Sep 29, 2021

Is there any way to produce a package which does not work with a consumer using esModuleInterop?

@legendecas
Copy link
Member Author

legendecas commented Sep 29, 2021

@dyladan yeah, the reason is exactly as same as previously discuss why we don't enable esModuleInterop in otel-js SDK. Check out https://github.com/legendecas/esmoduleinterop if you would like to play around. (This is exactly the inverted example of @meteorlxy provided)

@dyladan
Copy link
Member

dyladan commented Sep 29, 2021

rerunning all tests to see if they pass with cache hits too

@dyladan
Copy link
Member

dyladan commented Sep 29, 2021

I opened a PR that will fix these tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants