Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package template engines version #2319

Merged

Conversation

jonchurch
Copy link
Contributor

@jonchurch jonchurch commented Jul 2, 2021

Which problem is this PR solving?

  • The packages template lists Node.js >=8.0.0 under supported engines in the default package.json. OTLP JS lists v8.5.0 as the min supported Node.js version. New packages that copy the template may fail to update the current default.

Short description of the changes

  • Bump the engines field in package.json to >=8.5.0 to be in line with Node.js version support of the project.

closes #2318

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #2319 (d658b3b) into main (4b3425d) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   92.77%   92.63%   -0.14%     
==========================================
  Files         145      142       -3     
  Lines        5216     5091     -125     
  Branches     1068     1047      -21     
==========================================
- Hits         4839     4716     -123     
+ Misses        377      375       -2     
Impacted Files Coverage Δ
...ontext-async-hooks/src/AsyncHooksContextManager.ts
...sync-hooks/src/AbstractAsyncHooksContextManager.ts
...async-hooks/src/AsyncLocalStorageContextManager.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package template node engine version
5 participants