-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @types/node to v14 #2236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2236 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 145 145
Lines 5221 5221
Branches 1070 1070
=======================================
Hits 4844 4844
Misses 377 377 |
@dyladan Something seems to be wrong here as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compat tests should stick on old node types
@dyladan seems renovate still tries to update node 8, 10 and 12 |
Yup. I wish there was some way to test renovate configs |
You can run the |
@@ -12,7 +12,7 @@ | |||
"@opentelemetry/tracing": "0.23.0" | |||
}, | |||
"devDependencies": { | |||
"@types/node": "10.17.60", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backwards-compat configs should stay on the corresponding major version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well sorry i was tired i guess i though it didn't update those. Can't we just close the PR since it only want to update them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dyladan tries since a while to convince renovate-bot to do what we want. Not sure if he wants to try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting pretty tired of trying, but it will just open another PR next time a major version is released (which admittedly doesn't happen that often)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @types/node 15.x and 16.x exist meanwhile. But it seems bot puts all it's work into updating backward-compat to v14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backwards-compat configs should stay on the corresponding major version
I give up on the stupid renovate configs for now. Someone else is welcome to give it a try if they have the patience. |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 14.x releases. However, if you upgrade to 14.x manually then Renovate will then reenable updates for minor and patch updates automatically. If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
This PR contains the following updates:
8.10.66
->14.17.6
12.20.16
->14.17.6
10.17.60
->14.17.6
Configuration
📅 Schedule: "before 3am on Friday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.