-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: url validation & README to prevent gRPC footguns. #2130
chore: url validation & README to prevent gRPC footguns. #2130
Conversation
049745c
to
8d9d0ef
Compare
8d9d0ef
to
93e8fb8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 140 140
Lines 5002 5002
Branches 1029 1029
=======================================
Hits 4642 4642
Misses 360 360 |
93e8fb8
to
52c810d
Compare
packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
edcb871
to
1b10595
Compare
packages/opentelemetry-exporter-collector-grpc/src/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
The thought occurs to me we can do one better than this by reading protocol and if http or https, default to port 80 or 443 respectively, to make things like |
From my perspective this looks good to merge but I want to make sure @obecny is ok with that first since he had a comment but hasn't approved yet. |
…n host specified without protocol (#2322) * fix regression from #2130 when host specified without protocol * Update util.test.ts * Apply suggestions from code review Co-authored-by: Naseem <naseemkullah@gmail.com> * revert package.json changes * Update util.ts * add tests as per @MSNev request * Update packages/opentelemetry-exporter-collector-grpc/src/util.ts Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: Naseem <naseemkullah@gmail.com>
Fixes issues encountered on an OTel evangelism livestream last week.
Which problem is this PR solving?
/v1/trace
or/v1/metrics
tourl
when changing from HTTP to gRPC, causing weird DNS errors.Short description of the changes
/
in url field.