Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instrumentation-http): add diag debug on http request events #2126

Merged
merged 7 commits into from
Sep 9, 2021
Merged

feat(instrumentation-http): add diag debug on http request events #2126

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acd95a7
feat: add diag debug on http request events
Asafb26 Apr 20, 2021
ecfb69a
Merge branch 'main' into http-debug-enrich-logger
dyladan Aug 4, 2021
3939884
Update packages/opentelemetry-instrumentation-http/src/http.ts
Asafb26 Aug 15, 2021
77d0c2f
Update packages/opentelemetry-instrumentation-http/src/http.ts
Asafb26 Aug 15, 2021
9c3ace6
fix: _diag private
Asafb26 Aug 16, 2021
60e8845
Merge branch 'main' into http-debug-enrich-logger
rauno56 Sep 6, 2021
915da21
Merge branch 'main' into http-debug-enrich-logger
obecny Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/opentelemetry-instrumentation-http/src/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,17 +338,20 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
this._closeHttpSpan(span);
});
response.on('error', (error: Err) => {
diag.debug('outgoingRequest on error()');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be outgoingRequest on response error() but then we probably need to change this line https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-instrumentation-http/src/http.ts#L314

Asafb26 marked this conversation as resolved.
Show resolved Hide resolved
dyladan marked this conversation as resolved.
Show resolved Hide resolved
utils.setSpanWithError(span, error, response);
this._closeHttpSpan(span);
});
}
);
request.on('close', () => {
diag.debug('outgoingRequest on request close()');
if (!request.aborted) {
this._closeHttpSpan(span);
}
});
request.on('error', (error: Err) => {
diag.debug('outgoingRequest on request error()');
Asafb26 marked this conversation as resolved.
Show resolved Hide resolved
utils.setSpanWithError(span, error, request);
this._closeHttpSpan(span);
});
Expand Down