chore: adding flarna to js approvers #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
=======================================
Coverage 92.51% 92.51%
=======================================
Files 173 173
Lines 6038 6038
Branches 1284 1284
=======================================
Hits 5586 5586
Misses 452 452 |
mwear
approved these changes
Jan 14, 2021
dyladan
approved these changes
Jan 14, 2021
|
Think we should wait for ack from @Flarna before merging this |
Flarna
approved these changes
Jan 14, 2021
vmarchaud
approved these changes
Jan 14, 2021
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
open-telemetry#1817) * fix(ci): use opentelemetrybot to sync package-lock.json on release PRs * fix: comment typo * fix: token is named RELEASE_PR_TOKEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to propose @Flarna as js approver. He is contributing in this project for quite long time and has done many contributions. Thx for your hard work.
https://github.com/open-telemetry/opentelemetry-js/commits?author=Flarna
https://github.com/open-telemetry/opentelemetry-js-contrib/commits?author=Flarna