Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement parent based sampler #1577

Merged
merged 11 commits into from
Oct 13, 2020
Merged

feat: implement parent based sampler #1577

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e69bd53
feat: implement parent based sampler
dyladan Oct 7, 2020
9a8e24a
chore: lint
dyladan Oct 7, 2020
25bb11b
chore: markdown lint
dyladan Oct 7, 2020
1ced8b7
Merge remote-tracking branch 'origin/master' into parent-or-else
dyladan Oct 7, 2020
728bdd6
chore: emit error when parent sampler configured with no root
dyladan Oct 7, 2020
73b83c1
chore: add documentation to sampler readme
dyladan Oct 9, 2020
6c6d4d7
chore: all private members prefix with _
dyladan Oct 9, 2020
ea7dd9a
chore: add fallback sampler if root is unconfigured
dyladan Oct 9, 2020
025aa5e
chore: lint
dyladan Oct 9, 2020
a518dd6
chore: remove trailing space
dyladan Oct 9, 2020
8a01d0d
Merge branch 'master' into parent-or-else
dyladan Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: lint
  • Loading branch information
@dyladan
dyladan committed Oct 9, 2020
commit 025aa5e063743cff8043b9576a83fbcbf0162180
4 changes: 3 additions & 1 deletion packages/opentelemetry-core/src/trace/sampler/ParentBasedSampler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ export class ParentBasedSampler implements Sampler {
this._root = config.root;

if (!this._root) {
globalErrorHandler(new Error("ParentBasedSampler must have a root sampler configured"))
globalErrorHandler(
new Error('ParentBasedSampler must have a root sampler configured')
);
this._root = new AlwaysOnSampler();
}

Expand Down