-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: b3 single header support #1560
Merged
Merged
Commits on Oct 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1c2e702 - Browse repository at this point
Copy the full SHA 1c2e702View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6665539 - Browse repository at this point
Copy the full SHA 6665539View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1c57a6 - Browse repository at this point
Copy the full SHA d1c57a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac47433 - Browse repository at this point
Copy the full SHA ac47433View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82e10f2 - Browse repository at this point
Copy the full SHA 82e10f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c3ca6 - Browse repository at this point
Copy the full SHA 63c3ca6View commit details -
fix: do not propagate parent spand id from b3
B3 has an option to propagate both span id and a parent span id so that both sides of request can share the same span id. This is a usecase that we do not support in OpenTelemetry and couldn't support even if we wanted to because parent span id is not readable outside of the export pipeline. This buggy implementation stores and propagates the extracted parent span id, which will break zipkin implementations as a result.
Configuration menu - View commit details
-
Copy full SHA for 3d7afd6 - Browse repository at this point
Copy the full SHA 3d7afd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for effcdf3 - Browse repository at this point
Copy the full SHA effcdf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfcf071 - Browse repository at this point
Copy the full SHA dfcf071View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7812a8 - Browse repository at this point
Copy the full SHA d7812a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc0bd33 - Browse repository at this point
Copy the full SHA dc0bd33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b9083 - Browse repository at this point
Copy the full SHA 39b9083View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d3518f - Browse repository at this point
Copy the full SHA 1d3518fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7b3dd5 - Browse repository at this point
Copy the full SHA b7b3dd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7150573 - Browse repository at this point
Copy the full SHA 7150573View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.