-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Hapi and Koa to default supported plugins #1440
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
- Coverage 93.89% 93.79% -0.11%
==========================================
Files 148 144 -4
Lines 4393 4079 -314
Branches 894 847 -47
==========================================
- Hits 4125 3826 -299
+ Misses 268 253 -15 |
Please add them to the plugins-node-all metapackage also. |
Can you also add them to the metapackage? |
Yes sorry just added! |
Seems like the metapackage is currently failing to build because "'@opentelemetry/koa-instrumentation@0.9.0' is not in the npm registry." |
I would rather block adding anything more to |
Sure :) |
@carolinee21 sorry to give you the runaround but can you remove the metapackage change for now? |
Yep, just did! Thanks |
Short description of the changes: