-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix histogram type documentation #1427
Merged
mayurkale22
merged 6 commits into
open-telemetry:master
from
TigerHe7:histogram-documentation-fix
Aug 17, 2020
Merged
chore: fix histogram type documentation #1427
mayurkale22
merged 6 commits into
open-telemetry:master
from
TigerHe7:histogram-documentation-fix
Aug 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TigerHe7
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
August 14, 2020 06:35
|
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
==========================================
- Coverage 94.10% 94.03% -0.07%
==========================================
Files 145 119 -26
Lines 4341 3889 -452
Branches 886 824 -62
==========================================
- Hits 4085 3657 -428
+ Misses 256 232 -24 |
dyladan
approved these changes
Aug 14, 2020
markwolff
reviewed
Aug 14, 2020
mayurkale22
approved these changes
Aug 14, 2020
vmarchaud
approved these changes
Aug 15, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1426
Issue:
The documentation for the
histogram
type is incorrect in stating that the explicit bucket boundaries are inclusive upper bounds when they are actually inclusive lower bounds.Changes: