Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deploy canary releases #1384

Merged
merged 5 commits into from
Aug 6, 2020
Merged

chore: deploy canary releases #1384

merged 5 commits into from
Aug 6, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 4, 2020

This will publish a canary version of opentelemetry js on every merge to master. The canary version can be installed by running npm install @opentelemetry/api@canary, replacing api with the package you wish to install.

@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #1384 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   94.03%   93.77%   -0.26%     
==========================================
  Files         149      149              
  Lines        4322     4322              
  Branches      880      880              
==========================================
- Hits         4064     4053      -11     
- Misses        258      269      +11
Impacted Files Coverage Δ
...lemetry-exporter-collector/src/transformMetrics.ts 83.87% <0.00%> (-11.83%) ⬇️

@obecny
Copy link
Member

obecny commented Aug 4, 2020

for testing purposes can you trigger this not only on master , unless you have already verified it is working fine ?

markwolff
markwolff approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@markwolff markwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for doing this! Should we rename nightly.yaml to canary.yaml?

@dyladan
Copy link
Member Author

dyladan commented Aug 4, 2020

for testing purposes can you trigger this not only on master , unless you have already verified it is working fine ?

I verified it the best I could without actually deploying to npm. https://github.com/open-telemetry/opentelemetry-js/runs/945162495?check_suite_focus=true In this action you can see it failed because the publish didn't actually run (missing --yes), but the versions appear to be correct.

@markwolff markwolff mentioned this pull request Aug 4, 2020
Merged
@dyladan dyladan added the enhancement New feature or request label Aug 5, 2020
@mayurkale22
Copy link
Member

Just curious to know, in case of failure do we get any notification or build failure alert ?

@dyladan
Copy link
Member Author

dyladan commented Aug 6, 2020

Just curious to know, in case of failure do we get any notification or build failure alert ?

I have been getting notified of failed github actions directly in the github notification UI. Maybe I have some setting enabled?

@dyladan dyladan merged commit 19ee3dc into open-telemetry:master Aug 6, 2020
@dyladan dyladan deleted the nightly-deploy branch August 6, 2020 12:28
jonahrosenblum pushed a commit to jonahrosenblum/opentelemetry-js that referenced this pull request Aug 8, 2020
@dyladan @jonahrosenblum
chore: deploy canary releases (open-telemetry#1384)
ef046b9
obecny added a commit that referenced this pull request Aug 17, 2020
@jonahrosenblum @dyladan
@obecny @aravinsiva @rubenvp8510 @mayurkale22 @naseemkullah @legendecas @markwolff @mwear @EdZou @reggiemcdonald @renovate-bot @srjames90 @davidwitten @mickdekkers
Add Graceful Shutdown Support (#1321)
b884eec 
* feat: graceful shutdown for tracing and metrics

* fix: wording in test case

* fix: typo

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: add callbacks to shutdown methods

* fix: merge conflict

* simplify meter shutdown code

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: fix one-liner

* private function name style fix

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: naming of private member variables

* fix: graceful shutdown now works in browser

* fix: window event listener will trigger once

* fix: modify global shutdown helper functions

* fix: remove callback from remove listener args

* fix: change global shutdown function names and simplify functionality

* fix: add rest of function refactoring and simplification

* fix: remove unintended code snippet

* fix: refactor naming of listener cleanup function and fix sandbox issue

* fix: make global shutdown cleanup local

* fix: change interval of MeterProvider collection to ensure it does not trigger through clock

* chore: removing _cleanupGlobalShutdownListeners

* fix: remove unnecesary trace provider member function

* Removing default span attributes (#1342)

* refactor(opentelemetry-tracing): removing default span attributes

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing default span attributed from tracer object

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing accidental add to package.json

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* feat: add baggage support to the opentracing shim (#918)

Co-authored-by: Mayur Kale <mayurkale@google.com>

* Add nodejs sdk package (#1187)

Co-authored-by: Naseem <naseemkullah@gmail.com>
Co-authored-by: legendecas <legendecas@gmail.com>
Co-authored-by: Mark Wolff <mrw00010@gmail.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>

* feat: add OTEL_LOG_LEVEL env var (#974)

* Proto update to latest to support arrays and maps (#1339)

* chore: 0.10.0 release proposal (#1345)

* fix: add missing grpc-js index (#1358)

* chore: 0.10.1 release proposal (#1359)

* feat(api/context-base): change compile target to es5 (#1368)

* Feat: Make ID generator configurable (#1331)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: require grpc-js instead of grpc in grpc-js example (#1364)

Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>

* chore(deps): update all non-major dependencies (#1371)

* chore: bump metapackage dependencies (#1383)

* chore: 0.10.2 proposal (#1382)

* fix: remove unnecesary trace provider member function

* refactor(metrics): distinguish different aggregator types (#1325)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* Propagate b3 parentspanid and debug flag (#1346)

* feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* feat: Collector Metric Exporter for the Web (#1308)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* Fix issues in TypeScript getting started example code (#1374)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* chore: deploy canary releases (#1384)

* fix: protos pull

* fix: address marius' feedback

* chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier

* fix: add documentation and cleanup code

* fix: remove async label from shutdown and cleanup test case

* fix: update controller collect to return promise

* fix: make downsides of disabling graceful shutdown more apparent

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
Co-authored-by: Aravin <34178459+aravinsiva@users.noreply.github.com>
Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com>
Co-authored-by: Mayur Kale <mayurkale@google.com>
Co-authored-by: Naseem <naseemkullah@gmail.com>
Co-authored-by: legendecas <legendecas@gmail.com>
Co-authored-by: Mark Wolff <mrw00010@gmail.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Co-authored-by: Naseem <naseem@transit.app>
Co-authored-by: Mark Wolff <mark.wolff@microsoft.com>
Co-authored-by: Cong Zou <32532612+EdZou@users.noreply.github.com>
Co-authored-by: Reginald McDonald <40721169+reggiemcdonald@users.noreply.github.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: srjames90 <srjames@lightstep.com>
Co-authored-by: David W <dwitt12345@gmail.com>
Co-authored-by: Mick Dekkers <mickdekkersnl@gmail.com>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@Aneurysm9 @dyladan
fix(instrumentation/aws-lambda): Ensure callback is only called once (o…
d822f75 
…pen-telemetry#1384)

* fix(instrumentation/aws-lambda): Ensure callback is only called once regardless how many providers are flushed

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Update plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix lint issue

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

---------

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@markwolff markwolff markwolff approved these changes

@obecny obecny obecny approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyladan @obecny @mayurkale22 @markwolff