Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch observer #1137

Merged
merged 30 commits into from
Jun 30, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5511aa9
chore: adding batch observer, some metrics refactoring
obecny Jun 3, 2020
72e00fb
chore: undo changes after testing
obecny Jun 3, 2020
8e26b73
chore: undo changes after testing
obecny Jun 3, 2020
2e8c892
chore: addressing comments
obecny Jun 4, 2020
8f1d3e6
Merge branch 'master' into batch-observer
obecny Jun 4, 2020
2d55754
chore: renaming observer into value observer, fixing few spotted issues
obecny Jun 4, 2020
54448d4
chore: missing renamed for ValueObserver
obecny Jun 4, 2020
e8cf27b
chore: removing unused class
obecny Jun 4, 2020
36fdc5b
chore: cleanup
obecny Jun 4, 2020
353c476
chore: refactoring, renaming aggregators
obecny Jun 8, 2020
4983115
chore: merge branch 'master' into batch-observer
obecny Jun 8, 2020
f3c2a55
chore: refactoring observer to have base class that can be extended
obecny Jun 8, 2020
02f3259
chore: changing aggregator for ValueObserver, exposing batcher so it …
obecny Jun 10, 2020
7948bb2
chore: merge branch 'master' into batch-observer
obecny Jun 10, 2020
c227d41
chore: addressing comments
obecny Jun 10, 2020
91b32e0
chore: addressing comments
obecny Jun 10, 2020
9111c34
chore: preventing user from updating observer after timeout or update
obecny Jun 10, 2020
aff4fc1
chore: aligning aggregators for value observer and recorder with rega…
obecny Jun 11, 2020
91a517b
Merge branch 'master' into batch-observer
obecny Jun 11, 2020
74be6fc
chore: fixing test
obecny Jun 11, 2020
4bfe858
chore: merge branch 'master' into batch-observer
obecny Jun 12, 2020
e42ca77
chore: fixes after merge
obecny Jun 12, 2020
7385657
chore: changes after review
obecny Jun 12, 2020
e22b982
chore: changes after review with some additional fixes around typing
obecny Jun 12, 2020
1874414
chore: changes after review
obecny Jun 12, 2020
18a8a86
chore: merge branch 'master' into batch-observer
obecny Jun 22, 2020
133625f
chore: lint
obecny Jun 22, 2020
5e52e03
chore: merge branch 'master' into batch-observer
obecny Jun 30, 2020
2214c9f
chore: reviews
obecny Jun 30, 2020
f1ac953
chore: typo
obecny Jun 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: merge branch 'master' into batch-observer
  • Loading branch information
obecny committed Jun 8, 2020
commit 49831152c2e254753be9b06ef60d150acc85536d
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export class PrometheusExporter implements MetricExporter {
);
break;

case MetricKind.OBSERVER: // deprecated
case MetricKind.OBSERVER: // @TODO remove later #1146
case MetricKind.VALUE_OBSERVER:
metric.set(
labelValues,
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-metrics/src/export/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export enum MetricKind {
COUNTER,
UP_DOWN_COUNTER,
VALUE_RECORDER,
OBSERVER, // deprecated
OBSERVER, // @TODO remove later #1146
SUM_OBSERVER,
UP_DOWN_SUM_OBSERVER,
VALUE_OBSERVER,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.