Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove first time contribution greeting #1134

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 2, 2020

As can be seen on this issue [1], the token supplied to the action has READ ONLY access to the repository, meaning it lacks sufficient permission to even comment on the PR. This is a severe limitation of github actions and may prevent us from being able to use it for many cases in the future. More info: https://github.community/t/github-actions-are-severely-limited-on-prs/18179?u=dyladan

@dyladan
Copy link
Member Author

dyladan commented Jun 2, 2020

The action failing caused this PR to be considered 'failed' #1133

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1134 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         116      116           
  Lines        3396     3396           
  Branches      686      686           
=======================================
  Hits         3134     3134           
  Misses        262      262           

@dyladan dyladan added the express label Jun 2, 2020
@dyladan dyladan merged commit b52d767 into open-telemetry:master Jun 2, 2020
@dyladan dyladan deleted the remove-greet branch June 2, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants