remove node 13 tests #1132
Merged
remove node 13 tests #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivkanya9146
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 116 116
Lines 3396 3396
Branches 686 686
=======================================
Hits 3134 3134
Misses 262 262 |
naseemkullah
approved these changes
Jun 1, 2020
|
It would be nice if you can remove the same from https://github.com/open-telemetry/opentelemetry-js#supported-runtimes list. |
Done:) |
mayurkale22
approved these changes
Jun 1, 2020
obecny
approved these changes
Jun 1, 2020
dyladan
approved these changes
Jun 2, 2020
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jun 2, 2020
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> fix: remove unused var Signed-off-by: Naseem <naseem@transit.app> fix: lint Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jun 2, 2020
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> fix: remove unused var Signed-off-by: Naseem <naseem@transit.app> fix: lint Signed-off-by: Naseem <naseem@transit.app>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* fix(restify): upgrade package to fix type problem * fix(restify): updated so types are not leaking through open-telemetry#1132 * fix(restify): lint fix * fix(restify): final fix up for linter * style: avoid checking in manually edited package.json * test: require restify again for every test * test: differenciate between thorwing and failing gracefully * test: use custom error * feat: support restify@5 * feat: support restify@7 * feat: support restify@8 * test: cleanup * test: anyfy arguments on the anonymous handler * chore: add tav + update supported versions * fix: turn off tests on node@18 which is not supported for restify * refactor: remove the import to after setting up instrumentation Co-authored-by: jscherer92 <jscherer92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
-remove node 13 tests
Short description of the changes
-removed node 13 tests.