Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test build #1107

Merged
merged 6 commits into from
May 26, 2020
Merged

chore: test build #1107

merged 6 commits into from
May 26, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented May 25, 2020

testing ...

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #1107 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         238      238           
  Lines        9085     9085           
  Branches      822      822           
=======================================
  Hits         8629     8629           
  Misses        456      456           

@obecny
Copy link
Member Author

obecny commented May 26, 2020

@dyladan
I have been trying to figure out why it was failing due to this -> #1105
but it is still failing locally, probably the mentioned fix might fix local problems. Anyway do you want to keep this too to have the same versions for installed packages ? You mentioned you are working also on this fix, is it valid ?, are you gonna prepare new PR with fixes for @types/node or I can push it here ?

@dyladan
Copy link
Member

dyladan commented May 26, 2020

You can go ahead and update @types/node here if you need. I was trying to fix the build failures caused by the new versions of eslint dependencies in #1094 but it ended up being quite the rabbit hole and the build is still not fixed there. #1081 also uses the versions of linting dependencies installed in node modules, which should help us avoid these versioning issues in the future.

@dyladan dyladan merged commit cfcf38e into open-telemetry:master May 26, 2020
@obecny obecny deleted the test_build branch May 27, 2020 15:31
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants