Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pipe resource through to MetricRecord #1049

Merged
merged 1 commit into from
May 13, 2020
Merged

chore: pipe resource through to MetricRecord #1049

merged 1 commit into from
May 13, 2020

Conversation

mwear
Copy link
Member

@mwear mwear commented May 12, 2020

Which problem is this PR solving?

Short description of the changes

  • This completes the process of piping the Resource assigned to a MetricProvider to the MetricRecords so that it is available in the export pipeline.

mayurkale22
mayurkale22 approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should keep an eye on open-telemetry/opentelemetry-specification#508.

@mayurkale22 mayurkale22 added enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2020
vmarchaud
vmarchaud approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

obecny
obecny approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dyladan
dyladan approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Important note, the exporter is still doing nothing with this.

@dyladan dyladan merged commit 1827870 into open-telemetry:master May 13, 2020
@mayurkale22 mayurkale22 mentioned this pull request May 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

@obecny obecny obecny approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource is missing in MetricRecord for MetricExporter
5 participants
@mwear @obecny @dyladan @vmarchaud @mayurkale22