Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct default propagator #869

Closed
dyladan opened this issue Mar 17, 2020 · 5 comments
Closed

Set correct default propagator #869

dyladan opened this issue Mar 17, 2020 · 5 comments
Assignees
@jonahrosenblum
Labels
good first issue Good for newcomers

Comments

@dyladan
Copy link
Member

dyladan commented Mar 17, 2020

Currently the default propagator is a noop propagator. According to the spec:

If offered, the global Propagators should default to a composite Propagator
containing W3C Trace Context and Correlation Context Propagators,
in order to provide propagation even in the presence of no-op
OpenTelemetry implementations.
@dyladan dyladan added bug Something isn't working nonconforming and removed bug Something isn't working labels Mar 17, 2020
@mayurkale22
Copy link
Member

AFAIK current default propagator is a HttpTraceContext propagator, right?

@dyladan
Copy link
Member Author

dyladan commented Mar 17, 2020

As I understand it this means the API default not the SDK default. You linked the SDK default.

@mayurkale22 mayurkale22 added up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Mar 17, 2020
@dyladan
Copy link
Member Author

dyladan commented Mar 17, 2020

It also implies the "noop" implementation needs to propagate context without creating new spans...

@jonahrosenblum
Copy link
Contributor

I would like to claim this issue.

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 12, 2020
@jonahrosenblum jonahrosenblum mentioned this issue Jun 18, 2020
Merged
@mayurkale22
Copy link
Member

Closed via #1218

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@osherv
feat(mongodb4): added mongodb4 instrumentation (open-telemetry#869)
47700e1 
* feat(mongodb4): added mongodb4 instrumentation

* feat(mongodb4): updated mongo hostname

* feat(mongodb4): fixed Amir's CR

* feat(mongodb4): fixed Amir's CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahrosenblum jonahrosenblum

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dyladan @mayurkale22 @jonahrosenblum