-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading version inside code #600
Comments
@open-telemetry/javascript-approvers |
Quick question: why do you want to generate version for each package, AFAIK this is only needed for core package (which we already have)? |
We don't have now one reliable way of getting the version of certain plugin. We were discussing with @dyladan last week to have something reliable that could be similar across all packages for web and node. |
so basically the short answer would be one script that can be used for all packages |
@mayurkale22 the reason is because you could theoretically have a different version of core than of a plugin. The version that a plugin claims to be should not depend on another package. Right now packages are version locked together, but this may not always be the case. |
Makes sense, thanks for the explanation. |
Keeps aligned with other packages in the repo. Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
There is a problem with getting version of package inside code. Using directly
package.json
works fine for node but for web it will always raise an error. This is because build version and source will have a different path topackage.json
.The solution done for core works fine
opentelemetry-js/packages/opentelemetry-core/scripts/version-update.js
Line 35 in b58ad10
I want to implement a script that will be generating the version for each of package to have consistency across all packages.
The text was updated successfully, but these errors were encountered: