You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that e.g. @opentelemetry/instrumentation-http or @opentelemetry/instrumentation-fetch all hard-depend on specific versions of e.g. @opentelemetry/instrumentation, core, semantic-conventions etc. Is this really desired?
FWIW all the instrumentation from opentelemetry-js-contrib seems to already do it that way.
If that seems OK (cc @pichlermarc who explained these concepts to me previously) and I am not misunderstanding something, I'd be happy to open a PR updating the version ranges accordingly.
TLDR: I would propose to change e.g. these dependencies in @opentelemetry/instrumentation-http:
Related to #4815
I noticed that e.g.
@opentelemetry/instrumentation-http
or@opentelemetry/instrumentation-fetch
all hard-depend on specific versions of e.g.@opentelemetry/instrumentation
, core, semantic-conventions etc. Is this really desired?Based on https://github.com/open-telemetry/opentelemetry-specification/blob/a03382ada8afa9415266a84dafac0510ec8c160f/specification/upgrading.md?plain=1#L97-L122, if I understand correctly, instrumentation should continue to work for following minor releases of core packages. By relaxing e.g.
@opentelemetry/core
dependencies to e.g.^1.26.0
etc. we could make compatibility much easier. As of now, it can be pretty hard to update instrumentation.FWIW all the instrumentation from opentelemetry-js-contrib seems to already do it that way.
If that seems OK (cc @pichlermarc who explained these concepts to me previously) and I am not misunderstanding something, I'd be happy to open a PR updating the version ranges accordingly.
TLDR: I would propose to change e.g. these dependencies in
@opentelemetry/instrumentation-http
:to
and do the same for all instrumentation packages in this monorepo.
The text was updated successfully, but these errors were encountered: