-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host API Documentation #440
Comments
How do you manage multiple versions (1.0.0, 2.0.0...) when packages will be released for production ? Do we display only the last ? |
I think always display the latest one and with the help of |
Can we use GitHub pages with this repo to start with and then potentially move to a hosted domain? I think GitHub pages supports custom domains |
a solution : TypeStrong/typedoc#737 (comment) |
If we want to host in GitHub Pages, here is how we can do it using circle ci to update docs each time master is built https://github.com/dyladan/opentelemetry-js/tree/ci-docs Output looks like this https://dyladan.github.io/opentelemetry-js/ This is the change I made to make it work dyladan@f5be3d8 Right now the ssh key fingerprint is for my fork, but if we want to do it we just need a deploy key created and I can make the PR. |
This looks really good 💯 IMO we should update the API docs on every release (post release script) rather than each time master is built. Otherwise users would see un-released features/APIs in the docs, that might lead to confusions and all. On top of that, the API update happens once in a while. WDYT? |
Yea I agree that it should happen on release. Is there some way to automate that? I don't know what our current release mechanism is, but if it adds a tag that could be used as a filter. We could also keep a branch named edit: it looks like the current release created and pushed a tag edit 2: looks like the current release is actually |
Additional note: Since the |
Sounds good to me. May be "OpenTelemetry API for JavaScript"
opentelemetry-js/packages/opentelemetry-types/src/trace/tracer.ts Lines 52 to 53 in 91fd682
|
No I just mean more end-to-end examples. The getting started guide will focus on how can I set up a tracing backend and use auto instrumentation to get traces, but there are additional use cases that should be covered. How can a library author add OpenTelemetry support and so on. The docs are currently useful from a "how do I call this method?" standpoint, but leave something to be desired in terms of "why do I call this method?" |
Updated it so that it only runs on semver style git tags ( One issue is that this depends on the git tag being created, which is not always the case currently (e.g. current release has no tag). Maybe we should talk about release automation in general at the SIG meeting |
Can someone assign this to me? I'll make a PR based on the tag triggered version Monday. |
Done. |
Per SIG meeting, decide where to host the generated docs (
npm run docs
oryarn docs
). Also, decide when to update the same, either on every new release or every pull requests merge.Few hosting options:
Github pages
Some external domain similar to opentracing - https://opentracing-javascript.surge.sh/
/cc @danielkhan
The text was updated successfully, but these errors were encountered: