Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpTraceContextPropagator should not have "HTTP" in the name #2428

Closed
aabmass opened this issue Aug 25, 2021 · 7 comments · Fixed by #2429
Closed

HttpTraceContextPropagator should not have "HTTP" in the name #2428

aabmass opened this issue Aug 25, 2021 · 7 comments · Fixed by #2429
Assignees

Comments

@aabmass
Copy link
Member

aabmass commented Aug 25, 2021

The W3C TraceContext propagator is called HttpTraceContextPropagator. I don't think the "HTTP" prefix should be in the name, since propagation is carrier-agnostic. Other OTel SDK names:

@dyladan
Copy link
Member

dyladan commented Aug 25, 2021

Discussed in SIG. We like TraceContextTextMapPropagator

@aabmass aabmass changed the title HTTPTraceContextPropagator should not have "HTTP" in the name HttpTraceContextPropagator should not have "HTTP" in the name Aug 26, 2021
@aabmass
Copy link
Member Author

aabmass commented Aug 26, 2021

@dyladan I just realized we have the same problem with the W3C Baggage propagator, which is called HttpBaggagePropagator

export class HttpBaggagePropagator implements TextMapPropagator {

I would guess W3CBaggagePropagator makes the most sense here.. But then we have TraceContextTextMapPropagator without "W3C" in it. Thoughts?

@dyladan
Copy link
Member

dyladan commented Aug 26, 2021

I think i'd rather have W3C in both of them. W3CTraceContextTextMapPropagator (a mouthful I know) and W3CBaggagePropagator.

@open-telemetry/javascript-maintainers thoughts?

@aabmass
Copy link
Member Author

aabmass commented Aug 26, 2021

One inconsistency there is the -TextMap- part. I think either both or neither should have it (they both implement TextMapPropagator)

@dyladan
Copy link
Member

dyladan commented Aug 26, 2021

W3CTraceContextTextMapPropagator and W3CBaggageTextMapPropagator ?

@obecny
Copy link
Member

obecny commented Aug 30, 2021

would be in favour of making them shorter W3CTraceContextPropagator and W3CBaggagePropagator ?

@dyladan
Copy link
Member

dyladan commented Aug 30, 2021

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants