-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove 'Http' from W3C propagator names #2429
fix!: remove 'Http' from W3C propagator names #2429
Conversation
7d201d3
to
492107a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2429 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 137 137
Lines 4993 4993
Branches 1056 1056
=======================================
Hits 4629 4629
Misses 364 364
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PTAL at #2428 (comment) and leave your thoughts. The baggage propagator also needs to be renamed and we need to decide on a name before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should add this change to the upgrade guidelines in the readme ?
c1b429a
to
280488c
Compare
- `HttpTraceContextPropagator` to `W3CTraceContextPropagator` - `HttpBaggagePropagator` to `W3CBaggagePropagator`
280488c
to
881703e
Compare
881703e
to
115134a
Compare
@vmarchaud thanks, I updated the README |
Which problem is this PR solving?
Fixes #2428
Short description of the changes
Renames:
HttpTraceContextPropagator
toW3CTraceContextPropagator
HttpBaggagePropagator
toW3CBaggagePropagator
This is a breaking change
Fix in the contrib repo: open-telemetry/opentelemetry-js-contrib#644. I didn't find any places that need updating in
opentelemetrry-js-api
oropentelemetry.io
repos.