Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Tracers should reference an InstrumentationLibrary rather than a Resource #1108

Closed
dyladan opened this issue May 26, 2020 · 1 comment · Fixed by #1171
Closed

[Spec] Tracers should reference an InstrumentationLibrary rather than a Resource #1108

dyladan opened this issue May 26, 2020 · 1 comment · Fixed by #1171
Assignees
@mwear

Comments

@dyladan
Copy link
Member

dyladan commented May 26, 2020 •
edited
Loading

Spec PR merged: open-telemetry/opentelemetry-specification#616

@mwear since you wrote the spec do you want to take this? If so, please assign yourself. If there is nothing to do, feel free to close this ticket.
@mwear
Copy link
Member

mwear commented May 26, 2020

It's somewhat in limbo based on: open-telemetry/opentelemetry-proto#150. I think we can move forward with these changes, and make updates if and when the protos are changed.

@mwear mwear self-assigned this May 26, 2020
@mwear mwear mentioned this issue Jun 10, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@Ugzuzg @Flarna @rauno56
feat: improve pino instrumentation by patching additional exports of …
4e4d22e 
…the same function (open-telemetry#1108)

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwear mwear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add instrumentation library and update collector exporter mwear/opentelemetry-js
2 participants
@dyladan @mwear