Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a hidden symbol property on request to stop tracing #1010

Closed
dyladan opened this issue May 2, 2020 · 1 comment
Closed

Consider using a hidden symbol property on request to stop tracing #1010

dyladan opened this issue May 2, 2020 · 1 comment
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@dyladan
Copy link
Member

dyladan commented May 2, 2020

Who removes the header in case http plugin is disabled?

Nobody. If this is important, maybe we should switch to use a hidden property on the request then? Or we could just wait for open-telemetry/opentelemetry-specification#530

I don't really like that we use header values as a signal between plugins. It is an observable side-effect, and quite an intrusive one at that. I much prefer the idea to use context to stop tracing.

Originally posted by @dyladan in #984 (comment)

I really don't like the idea of using header values to signal between plugins, but there is a spec change coming down the pipe that might fix this anyway with a context property that stops tracing.

@dyladan dyladan added the Discussion Issue or PR that needs/is extended discussion. label May 2, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
removed \n in test to avoid OS and .gitattributes dependencies.
@pichlermarc
Copy link
Member

pichlermarc commented Mar 8, 2024

Closing this as we now have suppressTracing() in @opentelemetry/core which I believe does do exactly this, but via context instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

2 participants