feat(sdk-metrics-base): add ValueType support for sync instruments (#…

…2776)
open-telemetry · Feb 14, 2022 · fd62fa4 · fd62fa4
1 parent e4aa9eb
commit fd62fa4
Show file tree

Hide file tree

Showing 3 changed files with 223 additions and 36 deletions.
diff --git a/experimental/packages/opentelemetry-sdk-metrics-base/src/Instruments.ts b/experimental/packages/opentelemetry-sdk-metrics-base/src/Instruments.ts
@@ -20,13 +20,19 @@ import { InstrumentDescriptor } from './InstrumentDescriptor';
 import { WritableMetricStorage } from './state/WritableMetricStorage';
 
 export class SyncInstrument {
-  constructor(private _writableMetricStorage: WritableMetricStorage, private _descriptor: InstrumentDescriptor) { }
+  constructor(private _writableMetricStorage: WritableMetricStorage, private _descriptor: InstrumentDescriptor) {}
 
   getName(): string {
     return this._descriptor.name;
   }
 
-  aggregate(value: number, attributes: metrics.Attributes = {}, context: api.Context = api.context.active()) {
+  protected _record(value: number, attributes: metrics.Attributes = {}, context: api.Context = api.context.active()) {
+    if (this._descriptor.valueType === metrics.ValueType.INT && !Number.isInteger(value)) {
+      api.diag.warn(
+        `INT value type cannot accept a floating-point value for ${this._descriptor.name}, ignoring the fractional digits.`
+      );
+      value = Math.trunc(value);
+    }
     this._writableMetricStorage.record(value, attributes, context);
   }
 }
@@ -39,7 +45,7 @@ export class UpDownCounter extends SyncInstrument implements metrics.UpDownCount
    * Increment value of counter by the input. Inputs may be negative.
    */
   add(value: number, attributes?: metrics.Attributes, ctx?: api.Context): void {
-    this.aggregate(value, attributes, ctx);
+    this._record(value, attributes, ctx);
   }
 }
 
@@ -56,7 +62,7 @@ export class Counter extends SyncInstrument implements metrics.Counter {
       return;
     }
 
-    this.aggregate(value, attributes, ctx);
+    this._record(value, attributes, ctx);
   }
 }
 
@@ -68,6 +74,6 @@ export class Histogram extends SyncInstrument implements metrics.Histogram {
    * Records a measurement. Value of the measurement must not be negative.
    */
   record(value: number, attributes?: metrics.Attributes, ctx?: api.Context): void {
-    this.aggregate(value, attributes, ctx);
+    this._record(value, attributes, ctx);
   }
 }