Add node 18 to tests and remove EoL node versions (#3048)

open-telemetry · Jun 23, 2022 · fa295a3 · fa295a3
1 parent b891509
commit fa295a3
Show file tree

Hide file tree

Showing 58 changed files with 92 additions and 126 deletions.
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -10,7 +10,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node_version: ["8", "10", "12", "14", "16"]
+        node_version:
+          - "14"
+          - "16"
+          - "18"
     runs-on: ubuntu-latest
     env:
       NPM_CONFIG_UNSAFE_PERM: true

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@ All notable changes to this project will be documented in this file.
 
 ### :house: (Internal)
 
+* test: add node 18 and remove EoL node versions [#3048](https://github.com/open-telemetry/opentelemetry-js/pull/3048) @dyladan
+
 ## 1.3.1
 
 ### :bug: (Bug Fix)

diff --git a/README.md b/README.md
@@ -46,7 +46,7 @@ This is the JavaScript version of [OpenTelemetry](https://opentelemetry.io/), a
 ## Compatibility Matrix
 
 | API Version | Core version | Experimental Packages |
-| ----------- |--------------| --------------------- |
+| ----------- | ------------ | --------------------- |
 | 1.1.x       | 1.1.x        | 0.28.x                |
 | 1.0.x       | 1.0.x        | 0.26.x, 0.27.x        |
 | 1.0.x       | 0.26.x       | -----                 |
@@ -138,19 +138,18 @@ If you are a library author looking to build OpenTelemetry into your library, pl
 
 ## Supported Runtimes
 
-| Platform Version | Supported                                       |
-|------------------|-------------------------------------------------|
-| Node.JS `v16`    | ✅                                               |
-| Node.JS `v14`    | ✅                                               |
-| Node.JS `v12`    | ✅                                               |
-| Node.JS `v10`    | ✅                                               |
-| Node.JS `v8`     | See [Node Support](#node-support) below         |
-| Web Browsers     | ✅ See [Browser Support](#browser-support) below |
+| Platform Version    | Supported                                       |
+| ------------------- | ----------------------------------------------- |
+| Node.JS `v18`       | ✅                                               |
+| Node.JS `v16`       | ✅                                               |
+| Node.JS `v14`       | ✅                                               |
+| Older Node Versions | See [Node Support](#node-support)               |
+| Web Browsers        | ✅ See [Browser Support](#browser-support) below |
 
 ### Node Support
 
-Automated tests are run using the latest release of each currently active version of Node.JS.
-While Node.JS v8 and v10 are no longer supported by the Node.JS team, the latest versions of Node.JS v8 and v10 are still included in our testing suite.
+Only Node.js Active or Maintenance LTS versions are supported.
+Previous versions of node _may_ work, but they are not tested by OpenTelemetry and they are not guaranteed to work.
 Please note that versions of Node.JS v8 prior to `v8.12.0` will NOT work, because OpenTelemetry Node depends on the `perf_hooks` module introduced in `v8.5.0` and `performance.timeOrigin` that is set correctly starting in `v8.12.0`.
 
 ### Browser Support
@@ -161,7 +160,7 @@ There is currently no list of officially supported browsers, but OpenTelemetry i
 ## Feature Status
 
 | Signal  | API Status  | SDK Status        |
-|---------|-------------|-------------------|
+| ------- | ----------- | ----------------- |
 | Tracing | Stable      | Release Candidate |
 | Metrics | Development | Development       |
 | Logs    | Roadmap     | Roadmap           |
@@ -220,18 +219,18 @@ Maintainers ([@open-telemetry/js-maintainers](https://github.com/orgs/open-telem
 ### API
 
 | Package                          | Description                                                                                                                                                                                    |
-|----------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| -------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | [@opentelemetry/api][otel-api]   | This package provides TypeScript interfaces, enums and no-op implementations for the OpenTelemetry core trace and metrics model. It is intended for use both on the server and in the browser. |
 | [@opentelemetry/core][otel-core] | This package provides default and no-op implementations of the OpenTelemetry api for trace and metrics. It's intended for use both on the server and in the browser.                           |
 
 ### Implementation / SDKs
 
-| Package                                | Description                                                                                                                                                                                                                                                  |
-|----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| [@opentelemetry/sdk-trace-base][otel-tracing] | This module provides a full control over instrumentation and span creation. It doesn't load [`async_hooks`](https://nodejs.org/api/async_hooks.html) or any instrumentation by default. It is intended for use both on the server and in the browser.        |
-| [@opentelemetry/sdk-metrics-base][otel-metrics] | This module provides instruments and meters for reporting of time series data.                                                                                                                                                                               |
-| [@opentelemetry/sdk-trace-node][otel-node]       | This module provides automatic tracing for Node.js applications. It is intended for use on the server only.                                                                                                                                                  |
-| [@opentelemetry/sdk-trace-web][otel-web]         | This module provides automated instrumentation and tracing for Web applications. It is intended for use in the browser only.                                                                                                                                 |
+| Package                                         | Description                                                                                                                                                                                                                                           |
+| ----------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| [@opentelemetry/sdk-trace-base][otel-tracing]   | This module provides a full control over instrumentation and span creation. It doesn't load [`async_hooks`](https://nodejs.org/api/async_hooks.html) or any instrumentation by default. It is intended for use both on the server and in the browser. |
+| [@opentelemetry/sdk-metrics-base][otel-metrics] | This module provides instruments and meters for reporting of time series data.                                                                                                                                                                        |
+| [@opentelemetry/sdk-trace-node][otel-node]      | This module provides automatic tracing for Node.js applications. It is intended for use on the server only.                                                                                                                                           |
+| [@opentelemetry/sdk-trace-web][otel-web]        | This module provides automated instrumentation and tracing for Web applications. It is intended for use in the browser only.                                                                                                                          |
 
 ### Compatible Exporters
 
@@ -272,7 +271,7 @@ These instrumentations are hosted at <https://github.com/open-telemetry/opentele
 ### Shims
 
 | Package                                                  | Description                                                                             |
-|----------------------------------------------------------|-----------------------------------------------------------------------------------------|
+| -------------------------------------------------------- | --------------------------------------------------------------------------------------- |
 | [@opentelemetry/shim-opentracing][otel-shim-opentracing] | OpenTracing shim allows existing OpenTracing instrumentation to report to OpenTelemetry |
 
 ## Upgrade guidelines

diff --git a/examples/basic-tracer-node/package.json b/examples/basic-tracer-node/package.json
@@ -16,7 +16,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/grpc-js/package.json b/examples/grpc-js/package.json
@@ -20,7 +20,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/grpc/package.json b/examples/grpc/package.json
@@ -20,7 +20,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/http/package.json b/examples/http/package.json
@@ -20,7 +20,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/https/package.json b/examples/https/package.json
@@ -21,7 +21,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/opentracing-shim/package.json b/examples/opentracing-shim/package.json
@@ -21,7 +21,7 @@
     "opentracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/otlp-exporter-node/package.json b/examples/otlp-exporter-node/package.json
@@ -20,7 +20,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/examples/tracer-web/package.json b/examples/tracer-web/package.json
@@ -20,7 +20,7 @@
     "web"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -24,6 +24,8 @@ All notable changes to experimental packages in this project will be documented
 
 ### :house: (Internal)
 
+* test: add node 18 and remove EoL node versions [#3048](https://github.com/open-telemetry/opentelemetry-js/pull/3048) @dyladan
+
 ## 0.29.2
 
 * Support for 1.3.1 of stable packages

diff --git a/...l/backwards-compatability/node10/index.ts → ...l/backwards-compatability/node14/index.ts b/...l/backwards-compatability/node10/index.ts → ...l/backwards-compatability/node14/index.ts
diff --git a/...ckwards-compatability/node10/package.json → ...ckwards-compatability/node14/package.json b/...ckwards-compatability/node10/package.json → ...ckwards-compatability/node14/package.json
@@ -1,8 +1,8 @@
 {
-  "name": "backcompat-node10",
+  "name": "backcompat-node14",
   "version": "0.29.2",
   "private": true,
-  "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK",
+  "description": "Backwards compatability app for node 14 types and the OpenTelemetry Node.js SDK",
   "main": "index.js",
   "scripts": {
     "test:backcompat": "tsc --noEmit index.ts && tsc --noEmit --esModuleInterop index.ts",
@@ -13,9 +13,12 @@
     "@opentelemetry/sdk-trace-base": "1.3.1"
   },
   "devDependencies": {
-    "@types/node": "10.17.60",
+    "@types/node": "^14.0.0",
     "typescript": "4.4.4"
   },
   "author": "OpenTelemetry Authors",
-  "license": "Apache-2.0"
+  "license": "Apache-2.0",
+  "engines": {
+    "node": ">=14"
+  }
 }
diff --git a/...kwards-compatability/node10/tsconfig.json → ...kwards-compatability/node14/tsconfig.json b/...kwards-compatability/node10/tsconfig.json → ...kwards-compatability/node14/tsconfig.json
diff --git a/...l/backwards-compatability/node12/index.ts → ...l/backwards-compatability/node16/index.ts b/...l/backwards-compatability/node12/index.ts → ...l/backwards-compatability/node16/index.ts
diff --git a/...ckwards-compatability/node12/package.json → ...ckwards-compatability/node16/package.json b/...ckwards-compatability/node12/package.json → ...ckwards-compatability/node16/package.json
@@ -1,8 +1,8 @@
 {
-  "name": "backcompat-node12",
+  "name": "backcompat-node16",
   "version": "0.29.2",
   "private": true,
-  "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK",
+  "description": "Backwards compatability app for node 16 types and the OpenTelemetry Node.js SDK",
   "main": "index.js",
   "scripts": {
     "test:backcompat": "tsc --noEmit index.ts && tsc --noEmit --esModuleInterop index.ts",
@@ -13,9 +13,12 @@
     "@opentelemetry/sdk-trace-base": "1.3.1"
   },
   "devDependencies": {
-    "@types/node": "12.20.37",
+    "@types/node": "^16.0.0",
     "typescript": "4.4.4"
   },
   "author": "OpenTelemetry Authors",
-  "license": "Apache-2.0"
+  "license": "Apache-2.0",
+  "engines": {
+    "node": ">=14"
+  }
 }
diff --git a/...kwards-compatability/node12/tsconfig.json → ...kwards-compatability/node16/tsconfig.json b/...kwards-compatability/node12/tsconfig.json → ...kwards-compatability/node16/tsconfig.json
diff --git a/experimental/backwards-compatability/node8/index.ts b/experimental/backwards-compatability/node8/index.ts
diff --git a/experimental/backwards-compatability/node8/package.json b/experimental/backwards-compatability/node8/package.json
diff --git a/experimental/backwards-compatability/node8/tsconfig.json b/experimental/backwards-compatability/node8/tsconfig.json
diff --git a/experimental/packages/exporter-trace-otlp-grpc/package.json b/experimental/packages/exporter-trace-otlp-grpc/package.json
@@ -32,7 +32,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/exporter-trace-otlp-http/package.json b/experimental/packages/exporter-trace-otlp-http/package.json
@@ -43,7 +43,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",

diff --git a/experimental/packages/exporter-trace-otlp-proto/package.json b/experimental/packages/exporter-trace-otlp-proto/package.json
@@ -32,7 +32,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-api-metrics/package.json b/experimental/packages/opentelemetry-api-metrics/package.json
@@ -41,7 +41,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json
@@ -32,7 +32,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-http/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-http/package.json
@@ -43,7 +43,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/package.json
@@ -32,7 +32,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-exporter-prometheus/package.json b/experimental/packages/opentelemetry-exporter-prometheus/package.json
@@ -29,7 +29,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/package.json b/experimental/packages/opentelemetry-instrumentation-fetch/package.json
@@ -34,7 +34,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",

diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json
@@ -31,7 +31,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-instrumentation-http/package.json b/experimental/packages/opentelemetry-instrumentation-http/package.json
@@ -31,7 +31,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/package.json b/experimental/packages/opentelemetry-instrumentation-xml-http-request/package.json
@@ -34,7 +34,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",