fix(sdk-metrics): fix duplicated registration of metrics for collectors

open-telemetry · Dec 15, 2022 · 9965e64 · 9965e64
1 parent 263ee61
commit 9965e64
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
     * `telemetry.sdk.language`
     * `telemetry.sdk.version`
 * fix(selenium-tests): updated webpack version for selenium test issue [#3456](https://github.com/open-telemetry/opentelemetry-js/issues/3456) @SaumyaBhushan
+* fix(sdk-metrics): fix duplicated registration of metrics for collectors [#TODO] @legendecas
 
 ### :books: (Refine Doc)
 

diff --git a/packages/sdk-metrics/src/state/MetricStorageRegistry.ts b/packages/sdk-metrics/src/state/MetricStorageRegistry.ts
@@ -96,7 +96,7 @@ export class MetricStorageRegistry {
       return null;
     }
 
-    const storages = this._sharedRegistry.get(expectedDescriptor.name);
+    const storages = storageMap.get(expectedDescriptor.name);
     if (storages === undefined) {
       return null;
     }

diff --git a/packages/sdk-metrics/test/state/MetricStorageRegistry.test.ts b/packages/sdk-metrics/test/state/MetricStorageRegistry.test.ts
@@ -401,7 +401,22 @@ describe('MetricStorageRegistry', () => {
 
       // registered the storage for each collector
       assert.deepStrictEqual(registry.getStorages(collectorHandle), [storage]);
+      assert.strictEqual(
+        registry.findOrUpdateCompatibleCollectorStorage(
+          collectorHandle,
+          descriptor
+        ),
+        storage
+      );
+
       assert.deepStrictEqual(registry.getStorages(collectorHandle2), [storage]);
+      assert.strictEqual(
+        registry.findOrUpdateCompatibleCollectorStorage(
+          collectorHandle2,
+          descriptor
+        ),
+        storage
+      );
     });
   });
 });