fix(instrumentation-http): use semantic convention metric descriptions (

#3710)
open-telemetry · Apr 4, 2023 · 73da976 · 73da976
1 parent 4b04407
commit 73da976
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 
 ### :bug: (Bug Fix)
 
+* fix(instrumentation-http): fixed description for http.server.duration metric [#3710](https://github.com/open-telemetry/opentelemetry-js/pull/3710)
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

diff --git a/experimental/packages/opentelemetry-instrumentation-http/src/http.ts b/experimental/packages/opentelemetry-instrumentation-http/src/http.ts
@@ -80,15 +80,15 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
     this._httpServerDurationHistogram = this.meter.createHistogram(
       'http.server.duration',
       {
-        description: 'measures the duration of the inbound HTTP requests',
+        description: 'Measures the duration of inbound HTTP requests.',
         unit: 'ms',
         valueType: ValueType.DOUBLE,
       }
     );
     this._httpClientDurationHistogram = this.meter.createHistogram(
       'http.client.duration',
       {
-        description: 'measures the duration of the outbound HTTP requests',
+        description: 'Measures the duration of outbound HTTP requests.',
         unit: 'ms',
         valueType: ValueType.DOUBLE,
       }

diff --git a/...imental/packages/opentelemetry-instrumentation-http/test/functionals/http-metrics.test.ts b/...imental/packages/opentelemetry-instrumentation-http/test/functionals/http-metrics.test.ts
@@ -82,7 +82,7 @@ describe('metrics', () => {
     assert.strictEqual(metrics[0].dataPointType, DataPointType.HISTOGRAM);
     assert.strictEqual(
       metrics[0].descriptor.description,
-      'measures the duration of the inbound HTTP requests'
+      'Measures the duration of inbound HTTP requests.'
     );
     assert.strictEqual(metrics[0].descriptor.name, 'http.server.duration');
     assert.strictEqual(metrics[0].descriptor.unit, 'ms');
@@ -119,7 +119,7 @@ describe('metrics', () => {
     assert.strictEqual(metrics[1].dataPointType, DataPointType.HISTOGRAM);
     assert.strictEqual(
       metrics[1].descriptor.description,
-      'measures the duration of the outbound HTTP requests'
+      'Measures the duration of outbound HTTP requests.'
     );
     assert.strictEqual(metrics[1].descriptor.name, 'http.client.duration');
     assert.strictEqual(metrics[1].descriptor.unit, 'ms');