chore(env): update default value for span's attributes/links/events c…

…ount #1675 (#2098)
open-telemetry · Apr 12, 2021 · 2260dd6 · 2260dd6
1 parent 5dbe53a
commit 2260dd6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/packages/opentelemetry-core/src/utils/environment.ts b/packages/opentelemetry-core/src/utils/environment.ts
@@ -99,9 +99,9 @@ export const DEFAULT_ENVIRONMENT: Required<ENVIRONMENT> = {
   OTEL_PROPAGATORS: ['tracecontext', 'baggage'],
   OTEL_RESOURCE_ATTRIBUTES: '',
   OTEL_SAMPLING_PROBABILITY: 1,
-  OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: 1000,
-  OTEL_SPAN_EVENT_COUNT_LIMIT: 1000,
-  OTEL_SPAN_LINK_COUNT_LIMIT: 1000,
+  OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: 128,
+  OTEL_SPAN_EVENT_COUNT_LIMIT: 128,
+  OTEL_SPAN_LINK_COUNT_LIMIT: 128,
 };
 
 /**

diff --git a/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts b/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts
@@ -71,9 +71,9 @@ describe('BasicTracerProvider', () => {
     it('should construct an instance with default trace params', () => {
       const tracer = new BasicTracerProvider({}).getTracer('default');
       assert.deepStrictEqual(tracer.getActiveTraceParams(), {
-        numberOfAttributesPerSpan: 1000,
-        numberOfEventsPerSpan: 1000,
-        numberOfLinksPerSpan: 1000,
+        numberOfAttributesPerSpan: 128,
+        numberOfEventsPerSpan: 128,
+        numberOfLinksPerSpan: 128,
       });
     });
 
@@ -85,8 +85,8 @@ describe('BasicTracerProvider', () => {
       }).getTracer('default');
       assert.deepStrictEqual(tracer.getActiveTraceParams(), {
         numberOfAttributesPerSpan: 100,
-        numberOfEventsPerSpan: 1000,
-        numberOfLinksPerSpan: 1000,
+        numberOfEventsPerSpan: 128,
+        numberOfLinksPerSpan: 128,
       });
     });
 
@@ -97,9 +97,9 @@ describe('BasicTracerProvider', () => {
         },
       }).getTracer('default');
       assert.deepStrictEqual(tracer.getActiveTraceParams(), {
-        numberOfAttributesPerSpan: 1000,
+        numberOfAttributesPerSpan: 128,
         numberOfEventsPerSpan: 300,
-        numberOfLinksPerSpan: 1000,
+        numberOfLinksPerSpan: 128,
       });
     });
 
@@ -110,8 +110,8 @@ describe('BasicTracerProvider', () => {
         },
       }).getTracer('default');
       assert.deepStrictEqual(tracer.getActiveTraceParams(), {
-        numberOfAttributesPerSpan: 1000,
-        numberOfEventsPerSpan: 1000,
+        numberOfAttributesPerSpan: 128,
+        numberOfEventsPerSpan: 128,
         numberOfLinksPerSpan: 10,
       });
     });