Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip tests for aws-sdk instrumentation on node 8 and 10 #951

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Mar 17, 2022

Which problem is this PR solving?

Strictly speaking we don't have a problem yet. aws-sdk is kind enough to give us a heads up during our tests:

@opentelemetry/instrumentation-aws-sdk: -- running test "npm run test" with aws-sdk (env: {})
@opentelemetry/instrumentation-aws-sdk: > @opentelemetry/instrumentation-aws-sdk@0.6.0 test /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-aws-sdk
@opentelemetry/instrumentation-aws-sdk: > nyc ts-mocha -p tsconfig.json --require '@opentelemetry/contrib-test-utils' 'test/**/*.test.ts'
@opentelemetry/instrumentation-aws-sdk: (node:72835) NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
@opentelemetry/instrumentation-aws-sdk: no longer support Node.js v10.24.1 as of January 1, 2022.
@opentelemetry/instrumentation-aws-sdk: To continue receiving updates to AWS services, bug fixes, and security
@opentelemetry/instrumentation-aws-sdk: updates please upgrade to Node.js 12.x or later.

It says they are not supporting anything below node 12 anymore. as of January 1st, 2022.

Short description of the changes

Disable running aws-sdk tests on node 8 and 10 before it actually breaks and causes confusion.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #951 (d46782f) into main (ffc8faa) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   95.91%   96.05%   +0.14%     
==========================================
  Files          13       24      +11     
  Lines         856     1395     +539     
  Branches      178      289     +111     
==========================================
+ Hits          821     1340     +519     
- Misses         35       55      +20     
Impacted Files Coverage Δ
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.44% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.91% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
... and 1 more

@rauno56 rauno56 merged commit 271f805 into open-telemetry:main Apr 4, 2022
@rauno56 rauno56 deleted the chore/skip-aws-sdk-node8-10 branch April 4, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants