Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add fs to release config #938

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 9, 2022

fs instrumentation release is skipped in #929 because it is missing from the config

@dyladan dyladan requested a review from a team March 9, 2022 16:36
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #938 (24537ba) into main (3ad1727) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35           

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't need to add those manually anymore with v3?

@Flarna
Copy link
Member

Flarna commented Mar 9, 2022

I thought we didn't need to add those manually anymore with v3?

no need anymore to update .release-please-manifest.json.

@dyladan
Copy link
Member Author

dyladan commented Mar 9, 2022

I thought we didn't need to add those manually anymore with v3?

config is required, manifest is not.

@dyladan dyladan merged commit cc37e3f into open-telemetry:main Mar 9, 2022
@dyladan dyladan deleted the add-fs branch March 9, 2022 19:45
@Flarna Flarna mentioned this pull request Mar 11, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants