fix: use SQL verb for mysql2 span name when query object is used #923
Conversation
| assert.strictEqual(spans[0].name, 'SELECT'); | ||
| assert.strictEqual( | ||
| spans[0].attributes[SemanticAttributes.DB_STATEMENT], | ||
| query |
There was a problem hiding this comment.
What is the type of this variable? Is this an object or a string?
There was a problem hiding this comment.
It's a string. Code is now updated
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 95.91% 96.10% +0.18%
==========================================
Files 13 16 +3
Lines 856 1000 +144
Branches 178 205 +27
==========================================
+ Hits 821 961 +140
- Misses 35 39 +4
|
nozik
force-pushed
the
fix_mysql2_span_name
branch
from
ebe8be2
to
38a18b6
Compare
dyladan
changed the title
nozik
force-pushed
the
fix_mysql2_span_name
branch
from
c21005c
to
c54657c
Compare
|
@blumamir Can you please merge? I've addressed your comment. Thanks! |
Yeah I just want to give a chance to other people that might want to review and comment. |
|
It can't be merged right now anyway as it is out of date with the base branch and you have not granted permission for maintainers to update your branch so I can't merge the latest main. |
|
@dyladan Rebased now. I'm having some issues with granting the permissions. Thanks |
|
Thanks. I'll merge when the checks pass |
Which problem is this PR solving?
Short description of the changes
Checklist
npm run test-all-versionsfor the edited package(s) on the latest commit if applicable.